Project

General

Profile

Actions

Patch #16319

closed

Random crash when using custom fields

Added by Felix Schäfer over 10 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Normal
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

We (Planio) have seen several random crashes when using custom fields and have narrowed the problem to the usage of super to access attribute setters and getters in ActiveRecord models. According the the ActiveRecord docs, the preferred way to set and get a value from within a custom setter and getter is to use read_attribute and write_attribute.


Files

16319.patch (884 Bytes) 16319.patch Felix Schäfer, 2014-03-11 15:56
fix-crash.diff (689 Bytes) fix-crash.diff Ebrahim Mohammadi, 2014-03-13 04:40
Actions #1

Updated by Felix Schäfer over 10 years ago

The attached patch changes the super calls in CustomField#possible_values and CustomField#possible_values= to read_attribute and write_attribute.

Actions #2

Updated by Etienne Massip over 10 years ago

  • Target version set to Candidate for next minor release
Actions #3

Updated by Ebrahim Mohammadi over 10 years ago

I experience some random crashed too. Isn't your problem the same as my problem which I worked around using the attached patch?

Actions #4

Updated by Jean-Philippe Lang over 10 years ago

  • Category set to Code cleanup/refactoring
  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang
  • Target version changed from Candidate for next minor release to 2.5.1

Patch applied in r12968, thanks.

Actions #5

Updated by Jean-Philippe Lang over 10 years ago

  • Status changed from Resolved to Closed

Merged.

Actions

Also available in: Atom PDF