Project

General

Profile

Actions

Defect #16619

closed

Mailer.token_for generates invalid message_id when using from address with full name

Added by David Robinson over 10 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Normal
Category:
Email notifications
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

The token generator in Mailer.rb (Mailer.token_for) has the following code:

host = Setting.mail_from.to_s.gsub(%r{^.*@}, '')

If you have configured Redmine to send from an address with both name and email, (f.ex. "Redmine Mailer<>") this results in a Message-id like the following being created:
<redmine.journal-2421.20140408113649@redmine.org>>

the double ">" at the end is considered illegal by some mail servers, and results in them rejecting it.

A possible solution could be the following:

host = Setting.mail_from.to_s.gsub(%r{(^.*@)|>}, '')

Actions

Also available in: Atom PDF