Defect #17669
closed
Non admin users can't modify public queries for all project
Added by Sébastien Pochiero over 10 years ago.
Updated about 10 years ago.
Description
non admin users can't modify/suppress public queries howhever the permission is checked in roles configuration.
- Status changed from New to Resolved
i found the solution in app\models\query.rb :
"Members can not edit public queries that are for all project (only admin is allowed to)"
i replaced the line :
"is_public? && @is_for_all && user.allowed_to?(:manage_public_queries, project)"
by :
"is_public? && user.allowed_to?(:manage_public_queries, nil, :global => true)"
- Status changed from Resolved to New
- Target version set to 2.5.3
- Target version deleted (
2.5.3)
- Status changed from New to Closed
- Target version set to 2.5.3
- Resolution set to Invalid
Source comment says it is intentional.
source:tags/2.5.2/app/models/query.rb#L271
# Members can not edit public queries that are for all project (only admin is allowed to)
is_public? && !@is_for_all && user.allowed_to?(:manage_public_queries, project)
- Subject changed from Can't modify public reports for non admin users. to Can't modify public queries for non admin users.
- Target version deleted (
2.5.3)
- Subject changed from Can't modify public queries for non admin users. to Non admin users can't modify public queries for all project
If I understand correctly, you'd like a user who only has rights on Project A to manage a public query that is also used by Project B ? If so I don't think this is a good idea in the general case, and I'm OK with the actual default behaviour. If you really need this maybe you could make a simple plugin or keep the local patch you found. If I don't understand the request correctly, please correct me ;-)
- Related to Defect #14239: Error 403 when trying to edit custom query added
- Related to Defect #28264: Global and public custom queries are shown as editable to non administrators in projects added
Also available in: Atom
PDF
Updated by 
Updated by Toshi MARUYAMA 
Updated by 
Updated by