Redmine

In source:/trunk/app/models/mail_handler.rb@13413#L424, whether String#force_encoding is defined is used to make a decision about Mail::RubyVer, which defines pick_encoding on everything but Ruby 1.8.

This is dangerous as it couples knowledge about Ruby 1.8 (String#force_encoding is not defined) with knowledge about the Mail gem internals (Mail::RubyVer.pick_encoding is not defined on 1.8), there is no guarantee that this will always be the case though.

The attached patch checks whether Mail::RubyVer.pick_encoding is defined before using it instead of using the indirection through whether String#force_encoding is defined or not.