Project

General

Profile

Actions
Copy link

Defect #19260

closed

Non-default identifier-less git repositories are undeletable

Added by Felix Schäfer over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Administration
Target version:
2.6.3
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:
2.5.2

Description

Git repositories without an identifier that are not default (because another repository in the project has been promoted as default) are not deletable. This was tested on 2.3 and 2.5, but the code seems to still be in use in current trunk.

This is due to http://www.redmine.org/projects/redmine/repository/entry/branches/2.6-stable/app/models/repository.rb#L41 preventing successful saving in http://www.redmine.org/projects/redmine/repository/entry/branches/2.6-stable/app/models/repository/git.rb#L254 and makes the before_destroy in repository.rb fail.

I'm not quite sure what the intent of the validation was, I guess to enforce that if there is a repository with no identifier it is the default, but it seems possible to work around that after the creation of the identifier-less repository.

Attached is a patch with a failing test, the test passes with the validation removed, and removing the validation causes no other tests to fail.

Files

repo_identifiers.diff (2.09 KB) repo_identifiers.diff Felix Schäfer, 2015-03-03 18:15
Actions
Copy link
 #1

Updated by Toshi MARUYAMA over 9 years ago

  • Target version set to 2.6.3
Actions
Copy link
 #2

Updated by Jean-Philippe Lang over 9 years ago

  • Subject changed from non-default identifier-less git repositories are undeletable to Non-default identifier-less git repositories are undeletable
  • Description updated (diff)
  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Patch applied in r14050, thanks.

Actions
Copy link
 #3

Updated by Jean-Philippe Lang over 9 years ago

  • Status changed from Resolved to Closed

Merged.

Actions
Copy link
 #4

Updated by Nicolas Rodriguez over 9 years ago

Hi!

This patch introduces the possibility of having 2 (or more) repositories with empty identifier.
Is this something intendend?

Maybe a self.save(validate: false) in clear_extra_info_of_changesets would have done the job too? (specially if the repository is about to be deleted)

Thanks,

Nicolas

Actions
Copy link
 #5

Updated by Toshi MARUYAMA over 9 years ago

Nicolas Rodriguez wrote:

Hi!

This patch introduces the possibility of having 2 (or more) repositories with empty identifier.
Is this something intendend?

Maybe a self.save(validate: false) in clear_extra_info_of_changesets would have done the job too? (specially if the repository is about to be deleted)

Thanks,

Nicolas

I have created #19400, because 2.6.3 was released.

Actions
Copy link
 #6

Updated by Nicolas Rodriguez over 9 years ago

  • File Configuration - test - Redmine.png added
Actions
Copy link
 #7

Updated by Toshi MARUYAMA over 9 years ago

  • File deleted (Configuration - test - Redmine.png)
Actions
Copy link

Also available in: Atom PDF