Actions
Defect #19835
closedNewlines stripped from CVS commit messages
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
I noticed this in 3.0.3 but I think the issue was introduced with this change.
This is on Linux with the 3.0.3 tarball, rails 4.2.1, ruby 2.2.2-p95, CVS 1.12.13 and mysql 5.6.24 with the msyql2 adapter.
A quick fix that seems to work is:
diff --git a/lib/redmine/scm/adapters/cvs_adapter.rb b/lib/redmine/scm/adapters/cvs_adapter.rb index 92be438..8aceca6 100644 --- a/lib/redmine/scm/adapters/cvs_adapter.rb +++ b/lib/redmine/scm/adapters/cvs_adapter.rb @@ -260,7 +260,7 @@ module Redmine # version.line_minus = 0 # end else - commit_log << line unless line =~ /^\*\*\* empty log message \*\*\*/ + commit_log << line << "\n" unless line =~ /^\*\*\* empty log message \*\*\*/ end end end
but I'm not sure if something should be done with the encoding.
Actions