Project

General

Profile

Actions

Patch #21137

closed

Rescue network level errors with LDAP auth

Added by Holger Just over 8 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Category:
LDAP
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Right now, only a small number of possible error cases is rescue inside the AuthSourceLdap model are rescued, namely errors happening on the LDAP protocol itself. This results in plain (and not really helpful) 500 errors on login for many common transient network errors, including an unstable connection between the app and the LDAP server, TLS certificate issues, DNS issues, changed firewalls...

The attached patch against current trunk at r14793 provides a list of exceptions that are explicitly rescued to show a nice error message to the user instead of just failing with an HTTP 500. This should result in much more pleasant experience for people using LDAP auth.

This patch was extracted from Planio.


Files


Related issues

Related to Redmine - Defect #5592: Better error page on LDAP Authentication errorClosed2010-05-25

Actions
Actions #1

Updated by Toshi MARUYAMA over 8 years ago

  • Target version set to 3.2.0
Actions #2

Updated by Jean-Philippe Lang over 8 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Thanks.

Actions #3

Updated by Go MAEDA about 2 years ago

  • Related to Defect #5592: Better error page on LDAP Authentication error added
Actions

Also available in: Atom PDF