Defect #21504: IssuePriority.position_name not recalculated every time it should - Redmine

Actions

Copy link

Defect #21504

closed

IssuePriority.position_name not recalculated every time it should

Added by Felix Schäfer over 9 years ago. Updated about 9 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Jean-Philippe Lang

Category:

Administration

Target version:

3.1.4

Start date:

Due date:

% Done:

Estimated time:

Resolution:

Fixed

Affected version:

Description

The position_name attribute of IssuePriority instances is currently only recalculated when the position of the IssuePriority instance changes source:/tags/3.2.0/app/models/issue_priority.rb#L22

However, the position_name should also be recalculated when the active attribute changes.

I would even argue that that operation is quick enough, and that changes to the IssuePriority list are not frequent and done by administrators, so that the recalculation of the position_name can be done on after_save without filtering.

Patch to follow.

Files

21504-recalculate_issue_priority_position_name_on_active_change.patch (2.12 KB) 21504-recalculate_issue_priority_position_name_on_active_change.patch

Felix Schäfer, 2015-12-13 21:06