Defect #22134

HTML markup discrepancy ol and ul at app/views/imports/show.html.erb

Added by Felix Schäfer almost 5 years ago. Updated almost 5 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:UI
Target version:3.2.2
Resolution:Fixed Affected version:

Description

In source:/trunk/app/views/imports/show.html.erb@15173#L6 there's an opening ol, then closed by an ul.

0001-tiny-csv-import-fixes-i18n-html-tag-mismatch.patch Magnifier (2.2 KB) Jens Krämer, 2016-03-03 10:14

issue-22134.diff Magnifier (531 Bytes) Toshi MARUYAMA, 2016-03-26 05:38

Associated revisions

Revision 15282
Added by Toshi MARUYAMA almost 5 years ago

German "error_invalid_csv_file_or_settings" typo fixed by Jens Krämer (#22319, #22134)

Revision 15283
Added by Toshi MARUYAMA almost 5 years ago

Merged r15282 from trunk to 3.2-stable (#22319, #22134)

German "error_invalid_csv_file_or_settings" typo fixed by Jens Krämer.

Revision 15292
Added by Jean-Philippe Lang almost 5 years ago

HTML markup discrepancy ol and ul at app/views/imports/show.html.erb (#22134).

Patch by Jens Krämer.

Revision 15309
Added by Jean-Philippe Lang almost 5 years ago

Merged r15292 (#22134).

History

#1 Updated by Jens Krämer almost 5 years ago

patch for this and #22135, and also fixes a typo in de.yml

#2 Updated by Toshi MARUYAMA almost 5 years ago

  • Subject changed from HTML markup discrepancy <ol></ul> to HTML markup discrepancy ol and ul at app/views/imports/show.html.erb

#3 Updated by Toshi MARUYAMA almost 5 years ago

  • File issue-22134.diffMagnifier added
  • Status changed from New to Confirmed
  • Assignee set to Jean-Philippe Lang
  • Target version set to 3.2.2

This is only show.html.erb patch from note-1.
I don't know it should use ol or ul.

#4 Updated by Jean-Philippe Lang almost 5 years ago

  • Category set to UI
  • Status changed from Confirmed to Resolved
  • Resolution set to Fixed

Committed, thanks.

#5 Updated by Jean-Philippe Lang almost 5 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF