Redmine

The patch is a good start and is in the correct format. There are a couple of improvements:

• Using send isn't necessary. issue.estimated_hours would work
• Some unit tests would be helpful

Another improvement would be to replace the entire loop with:

@issues.collect(&:estimated_hours).reject {|hours| hours.nil?}.sum

Or:

@issues.collect(&:estimated_hours).compact.sum

But the problem is that it calculates the total for the issues that are displayed only.
If the issue list has more than one page, this is a partial sum.

If we really want to add this feature, we'd better do a query to sum the estimated hours of all the filtered issues. IMHO, it makes more sense.

Adding something like this to the controller should almost work (not tested):

@estimated = Issue.sum :estimated_hours, 
                       :include => [ :status, :project ],
                       :conditions => @query.statement

Jean-Philippe Lang wrote:

But the problem is that it calculates the total for the issues that are displayed only.
If the issue list has more than one page, this is a partial sum.

Opps, I thought that was what the feature was for "xxx time in the list"

Adding up the total estimated time for all issues (visible or not) might be dangerous - what if we click "All Issues" on a big database with thousands of issues - will they all be loaded into memory in order to sum their estimated time (unsure whether Active Record does this in memory or is smart and just calls "Select sum(EstimatedTime) from ..." ect).

I use the original patch daily and am very happy with it - if it is to be improved I would rather see subtotals for each discrete value in the sorted column before grand totals for all records.

Ewan Makepeace: Good thinking. Active Record does it as a single SUM query so it should be fine.

SQL (0.000110) SELECT sum(`issues`.estimated_hours) AS sum_estimated_hours FROM `issues` LEFT OUTER JOIN `issue_statuses` ON `issue_statuses`.id = `issues`.status_id LEFT OUTER JOIN `projects` ON `projects`.id = `issues`.project_id WHERE ((issue_statuses.is_closed=0) AND ((projects.status=1 AND EXISTS (SELECT em.id FROM enabled_modules em WHERE em.name='issue_tracking' AND em.project_id=projects.id)) AND (1=0 OR projects.is_public = 1)))

Ewan Makepeace wrote:

Adding up the total estimated time for all issues (visible or not) might be dangerous - what if we click "All Issues" on a big database with thousands of issues - will they all be loaded into memory in order to sum their estimated time (unsure whether Active Record does this in memory or is smart and just calls "Select sum(EstimatedTime) from ..." ect).

I wouldn't have submitted such code if I was unsure of what Issue.sum does.

Hi Evan,
Can you please share your patch in some way? I'd like to have it very much.
Thanks!

Victor See here: #4776

As mentioned the first time by Tony Marschall in #8559 note-4, there exists a plugin which provides (parts of) this feature (along with some others): Redmine spent time column. It's written by Jan Schulz-Hofen of plan.io.

I've started working on some improvements to make it better suitable for this issue in my fork of it:
https://github.com/MischaTheEvil/redmine_spent_time_column

are there sulutions for redmine 2.5 ?

Mischa The Evil The Evil,
as i see i can not install your fork of the plugin, maybe because we use redmine 2.6.1???

@all
This would be an awesome feature for us! We want to use our redmine system for our capacity planning. This would improve our work enormously :)

To clarify - the previous post by Muhammad Azmi contains the current version of our patches to show estimated time totals on groups and at the foot of pages as originally described.