Project

General

Profile

Actions

Defect #23031

closed

CSS Wrong icon for details

Added by César DJ Caësar 9114 over 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
UI
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Wont fix
Affected version:

Description

Hello,
I'm currently developing a plugin for Redmine, and I saw that there may be a mistake regarding a class:

.icon-details  { background-image: url(../images/zoom-in.png); }

I would have written:

.icon-details  { background-image: url(../images/magnifier.png); }

Because "zoom-in" already exists here:

.icon-zoom-in { background-image: url(../images/zoom_in.png); }

And "magnifier" doesn't exist anywhere.


Related issues

Related to Redmine - Patch #24578: Remove unused CSS class ".icon-details"ClosedJean-Philippe Lang

Actions
Actions #1

Updated by Jean-Philippe Lang over 8 years ago

You should use .icon-magnifier which uses magnifier.png. .icon-details class is no longer used and should be removed.

Actions #2

Updated by César DJ Caësar 9114 over 8 years ago

Jean-Philippe Lang wrote:

You should use .icon-magnifier which uses magnifier.png. .icon-details class is no longer used and should be removed.

Merci Jean-Philippe, but I'm currently using version 3.2.1 (stable) of Redmine, and there is no .icon-magnifier. There is a -search-margnifier in responsive.css, though.

I may have missed something but I looked among all the files using:

grep -rnw '/usr/share/redmine/' -e "magnifier" 

Actions #3

Updated by Go MAEDA almost 8 years ago

  • Related to Patch #24578: Remove unused CSS class ".icon-details" added
Actions #4

Updated by Go MAEDA almost 8 years ago

  • Category changed from Themes to UI
  • Status changed from New to Closed
  • Resolution set to Wont fix

Since I have created a issue #24578 to remove icon-details, I am closing this issue.

César Lizurey wrote:

Merci Jean-Philippe, but I'm currently using version 3.2.1 (stable) of Redmine, and there is no .icon-magnifier. There is a -search-margnifier in responsive.css, though.

.icon-magnifier was introduced in Redmine 3.3.0.

Actions

Also available in: Atom PDF