Patch #23519
Don't preload projects and roles on Principal#memberships association
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Jean-Philippe Lang | % Done: | 0% | |
| Category: | Performance | |||
| Target version: | 3.4.0 |
Description
Why it should preload project and roles by default? it is not used over the redmine much, and somewhare it is not good to preloading those associations.
memberships_performance.diff 
(3.42 KB)
memberships_performance.diff
- v2 - no reason to use preload for one entity
(3.13 KB)
Associated revisions
Don't preload projects and roles on Principal#memberships association (#23519).
Patch by Ondřej Ezr.
Reset #roles on reload (#23519).
Don't destructively insert builtin_role into roles (#23519).
Preload :roles for displaying user memberships (#23519).
History
#1
Updated by Ondřej Ezr over 4 years ago
- File memberships_performance.diff added
No reason for preload in membership(...)
#2
Updated by Toshi MARUYAMA over 4 years ago
- Target version set to 3.4.0
#3
Updated by Jean-Philippe Lang almost 4 years ago
- Subject changed from Performance for memberships to Don't preload projects and roles on Principal#memberships association
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
Patch committed, thanks. FTR, the proposed patch was not working as expected and broke a few tests, #roles has to be called explicitly (using self.roles) due to a variable naming clash in #allowed_to?.