Patch #23519
closed
Don't preload projects and roles on Principal#memberships association
Added by Ondřej Ezr over 8 years ago.
Updated almost 8 years ago.
Description
Why it should preload project and roles by default? it is not used over the redmine much, and somewhare it is not good to preloading those associations.
Files
No reason for preload in membership(...)
- Target version set to 3.4.0
- Subject changed from Performance for memberships to Don't preload projects and roles on Principal#memberships association
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
Patch committed, thanks. FTR, the proposed patch was not working as expected and broke a few tests, #roles
has to be called explicitly (using self.roles
) due to a variable naming clash in #allowed_to?
.
Also available in: Atom
PDF