Patch #239

Adds two blocks for my/page and fixes a report bug

Added by Rocco Stanzione almost 13 years ago. Updated over 9 years ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:My page
Target version:-

Description

This fixes a report query filter bug where assigned_to="me", and adds two new blocks for my/page, for a manager's
dashboard - issues due in the next week and past due issues.

blocks.diff Magnifier (2.83 KB) Rocco Stanzione, 2008-02-03 11:01


Related issues

Related to Redmine - Feature #12789: Redmine - design study New

History

#1 Updated by Jean-Philippe Lang almost 13 years ago

I think I found the bug.
But I applied a different fix (in r979) because I don't want
that the "me" value appears when the user is not logged
(since the app don't know who he is).

#2 Updated by Rocco Stanzione almost 13 years ago

What do you when ? You get an error or the filter is not

takeninto accout ?

The filter is incorrect (if I remember right, the SQL says
assigned_to='') and no results are returned.

In fact, User.current is never nil.

That's the idea. Possibly I'm missing something, but
User.current.logged? looked like an unnecessary step that
was returning the wrong results, so I circumvented
executed_by with User.current.

#3 Updated by Jean-Philippe Lang almost 13 years ago

If I set a filter like assigned_to="me", it often

(but not always) wouldn't work

What do you when ? You get an error or the filter is not taken
into accout ?

by assuming that if User.current is not nil

In fact, User.current is never nil.

#4 Updated by Rocco Stanzione almost 13 years ago

Maybe I should have better documented the bug before
submitting the fix. If I set a filter like
assigned_to="me", it often (but not always) wouldn't
work
because executed_by was nil, apparently because
User.current.logged? was returning false. This patch makes
it work by assuming that if User.current is not nil,
User.current is logged in and should be treated as
"me".

#5 Updated by Jean-Philippe Lang almost 13 years ago

This fixes a report query filter bug where

assigned_to="me"

Could you tell more about this bug ?

#6 Updated by Toshi MARUYAMA over 9 years ago

  • Category set to My page

Also available in: Atom PDF