Redmine

Elements of datetime.distance_in_words should not be used outside of the method distance_of_time_in_words. Please duplicate the x_days and x_hours strings outside of the distance_in_words array in the language files and use those where needed.

Does it help if I attach a patch?

x_days is currently:

          one: '1 napja'
          other: '%{count} napja'

label_added_time_by: "%{author} adta hozzá %{age}".

While x_hours is

        one:   "1 óra" 
        other: "%{count} óra" 

• In issue_relation.rb
  

    def to_s(issue=nil)
      issue ||= issue_from
      issue_text = block_given? ? yield(other_issue(issue)) : "##{other_issue(issue).try(:id)}" 
      s = []
      s << l(label_for(issue))
      s << "(#{l('datetime.distance_in_words.x_days', :count => delay)})" if delay && delay != 0
      s << issue_text
      s.join(' ')
    end
  

  needs the root word nap instead of datetime.distance_in_words.x_days.

• session_lifetime_options
  needs the root words (óra and nap) instead of datetime.distance_in_words.x_hours and datetime.distance_in_words.x_days;

• session_timeout_options
  needs the root word óra instead of datetime.distance_in_words.x_hours.

• autologin
  Instead of datetime.distance_in_words.x_days, we either need "x napig" (for/up to x day(s)), or - better yet - we need the root word nap AND setting_autologin needs to be changed to Automatikus bejelentkezés érvényességi ideje (... ~ expiration time).

• password_max_age
  Instead of datetime.distance_in_words.x_days, we need the root word nap.

In Russian source:tags/3.3.2/config/locales/ru.yml#L124

      x_days:
        one:   "%{count} день" 
        few:   "%{count} дня" 
        many:  "%{count} дней" 
        other: "%{count} дня" 

Toshi MARUYAMA wrote:

In Russian source:tags/3.3.2/config/locales/ru.yml#L124

What do you mean by that note?
I've found what you mean here.
That's a whole different problem. Hungarian uses the same singular nouns after any number.

Alas, I cannot change the subject, but this issue is about the misusing of distance_in_words array. See note-1.

"distance_in_words" is Rails core feature.

Toshi MARUYAMA wrote:

"distance_in_words" is Rails core feature.

So? Have you read my note-1?
"Elements of datetime.distance_in_words should not be used outside of the method distance_of_time_in_words."

Greg T wrote:

Toshi MARUYAMA wrote:

"distance_in_words" is Rails core feature.

So? Have you read my note-1?
"Elements of datetime.distance_in_words should not be used outside of the method distance_of_time_in_words."

Please post a patch because I cannot understand.

See issue #25402 with my patch.

Would you accept my patch, please?

Where did you pick datetime.x_hours and datetime.x_days from in other languages?

Would you accept my patch, please?

I will try to understand the expression of numbers and "ago" in Hungarian, to understand the patch.

p.s. My native language is Japanese. It is also agglutinative language.

Go MAEDA wrote:

I will try to understand the expression of numbers and "ago" in Hungarian, to understand the patch.

p.s. My native language is Japanese. It is also agglutinative language.

Thanks. I chose a wrong subject that I'm not allowed to modify here. I think I have a better description in Patch #25402 ("stop misusing distance_in_words").

How can I help?

Will you ever accept my patches, please?

Greg T wrote:

When x_hours and x_days are not used for a reference to a past point in time relative to the present moment then datetime.distance_in_words must not be used as it's impossible to fix the Hungarian/Magyar language files that way.

Go MAEDA wrote:

I will try to understand the expression of numbers and "ago" in Hungarian, to understand the patch.
p.s. My native language is Japanese.

Examples by Google Translates:
en
It happened 8 hours ago.
Session maximum lifetime: 8 hours.
It happened 8 years ago.
Session maximum lifetime: 8 years.

ja (I don't know kanjis/Japanese at all, sorry.)
Sore wa 8-jikan mae ni okorimashita.
Sesshon no saidai yūkōkigen: 8-Jikan.
Sore wa 8-nen mae ni okorimashita.
Sesshon no saidai yūkōkigen: 8-Nen.

hu
8 órával ezelőtt történt.
A munkamenet maximális élettartama: 8 óra.
8 évvel ezelőtt történt.
A munkamenet maximális élettartama: 8 év.