Actions
Patch #26522
closedRepository routing bug when file path starts with (browse|entry|raw|changes|annotate|diff)/
Start date:
Due date:
% Done:
0%
Estimated time:
Description
If the first component of a path in a repository equals one of the strings above, the wrong route gets selected in the case of links without repository_id
(as they are generated from wiki source:
links to the default repository of a project) and the intended action is mistaken for the repository_id
parameter. Attached is a patch to the repository routing test illustrating the issue.
I would suggest to change repository#identifier_param to always return an identifier (see second patch) and remove the repository routes without repository_id (rows 280ff in current config/routes.rb).
Files
Related issues
Updated by Jean-Philippe Lang over 6 years ago
- Subject changed from repository routing bug when file path starts with (browse|entry|raw|changes|annotate|diff)/ to Repository routing bug when file path starts with (browse|entry|raw|changes|annotate|diff)/
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
Routes without repository_id are removed.
Updated by Holger Just about 3 years ago
- Related to Defect #35885: the change of routing raw files from repositories not included in the upgrade proces/manual added
Actions