Defect #26645
closed
  
        
        Added by Philip Taffner about 8 years ago.
        Updated about 8 years ago.
        
  
  
  
  Description
  
  There is no "--no-color" argument for "git version" anymore.
	Potential fix:
Index: lib/redmine/scm/adapters/git_adapter.rb
===================================================================
--- lib/redmine/scm/adapters/git_adapter.rb     (revision 16828)
+++ lib/redmine/scm/adapters/git_adapter.rb     (working copy)
@@ -54,7 +54,7 @@
           end
           def scm_version_from_command_line
-            shellout("#{sq_bin} --version --no-color") { |io| io.read }.to_s
+            shellout("#{sq_bin} --version") { |io| io.read }.to_s
           end
         end
   
 
 
  
  
    
    
    
    
       - Related to Defect #5324: Git not working if color.ui is enabled added
 
    
    
     
   
  
  
    
    
    
    
$ ./git --version
git version 2.14.0
$ ./git --version --no-color
error: unknown option `no-color'
usage: git version [<options>]
    --build-options       also print build options
$ ./git log --no-color | wc
 753470 3494163 28722346
$ ./git log | wc
 753470 3494163 28722346
$ ./git config -l | grep color
color.ui=true
 
     
   
  
  
    
    
    
    
       - Subject changed from git 2.14 breaks fetch_changesets to git 2.14 comatibility
 
    
    
     
   
  
  
    
    
    
    
       - Subject changed from git 2.14 comatibility to git 2.14 compatibility
 
    
    
     
   
  
  
    
    
    
    
       - Target version set to 3.3.5
 
    
    I have committed r16948.
We cannot use self.superclass.client_version_above? because "git --version --no-color" fails.
I think I added "--no-color" to "git --version" at r4885 for preventing feature brokenness.
 
     
   
  
  
    
    
    
    
       - Status changed from New to Closed
 
       - Resolution set to Fixed
 
    
    Committed in turnk, 3.4-stable, and 3.3-stable.
 
     
   
  
  
    
    
    
    
       - Has duplicate Defect #26765: Redmine 3.3.3.stable Cannot find binary for Git 2.14  added
 
    
    
     
   
  
  
  
 
  
  
  
 
Also available in:  Atom
  PDF