Defect #26699
closed
Anonymous user should have their icon
0%
Description
ApplicationHelper#avatar method returns blank string instead of img tag for the anonymous user. The behavior causes disordered layout in IssuesController#show page.
This patch adds an icon for the anonymous user and fixes the broken layout.
Before:
The author of the issue is the anonymous user. But in the upper left corner of the page, the assignee's icon is displayed as if it is the author's icon because the anonymous user does not have their avatar icon.
No icon is displayed in the journal which was made by the anonymous user.
After:
New anonymous icon is displayed.
Files
Related issues
Updated by Go MAEDA over 7 years ago
- Related to Patch #25775: Show assignee's icon in addition to author's icon added
Updated by Go MAEDA over 7 years ago
Updated tests.
Updated by Go MAEDA over 7 years ago
- File deleted (
0001-Add-avatar-for-anonymous-user.patch)
Updated by Go MAEDA over 7 years ago
- Target version set to 3.4.3
I think it is problematic that an assignee's icon looks like an author's icon in Redmine 3.4 when the issue's author is an anonymous user.
I suggest including this fix in 3.4.3.
Updated by Jean-Philippe Lang about 7 years ago
- Target version changed from 3.4.3 to 3.4.4
I think it would be better to use the default gravatar icon instead of using our own.
What do you think?
Updated by Go MAEDA about 7 years ago
Jean-Philippe Lang wrote:
I think it would be better to use the default gravatar icon instead of using our own.
What do you think?
I prefer to have a special icon for anonymous user. We cannot distinguish a regular user with no Gravatar icon and anonymous user if default Gravatar icon is used for anonymous users.
Updated by Mischa The Evil about 7 years ago
Go MAEDA wrote:
[...]
I prefer to have a special icon for anonymous user. We cannot distinguish a regular user with no Gravatar icon and anonymous user if default Gravatar icon is used for anonymous users.
I agree with Go MEADA on this. We should be able to distinguish between regular users without Gravatar and anonymous user(s).
Updated by Jean-Philippe Lang almost 7 years ago
- Status changed from New to Closed
- Resolution set to Fixed
Committed, thanks.
Updated by Jean-Philippe Lang almost 7 years ago
- Target version changed from 3.4.4 to 3.3.6
Updated by Go MAEDA almost 7 years ago
- Related to Defect #28204: Too large avatar breaks gantt when assignee is a group added
Updated by Go MAEDA almost 7 years ago
- Related to Defect #28208: Anonymous icon is wrongly displayed when assignee is a group added