Actions
Patch #26728
closed
count > 0 vs exists?
Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Code cleanup/refactoring
Target version:
-
Start date:
Due date:
% Done:
0%
Estimated time:
Description
redmine/app/models/project.rb:671: if versions.count > 0 redmine/app/views/imports/show.html.erb:3:<% if @import.saved_items.count > 0 %> redmine/app/views/imports/show.html.erb:15:<% if @import.unsaved_items.count > 0 %>
could be
redmine/app/models/project.rb:671: if versions.exists? redmine/app/views/imports/show.html.erb:3:<% if @import.saved_items.exists? %> redmine/app/views/imports/show.html.erb:15:<% if @import.unsaved_items.exists?%>
Related issues
Updated by Toshi MARUYAMA over 7 years ago
- Category set to Code cleanup/refactoring
- Status changed from New to Needs feedback
Please post by patch.
Updated by Toshi MARUYAMA over 7 years ago
And please describe why this change is effective.
Updated by Toshi MARUYAMA over 7 years ago
Toshi MARUYAMA wrote:
Please post by patch.
Please post by attachment patch file.
Updated by Go MAEDA over 6 years ago
- Related to Patch #24839: Minor performance improvement - Replace count by exists? added
Updated by Go MAEDA over 6 years ago
- Status changed from Needs feedback to Closed
We have decided not to use exists? there. Please see #24839#note-1 and #24839#note-3.
Actions