Patch #27114
closed
Make robust Redmine::Helpers::URL#uri_with_safe_scheme?
Added by okkez _ over 7 years ago.
Updated about 7 years ago.
Description
I'm developing new formatter for CommonMark.
commonmarker gem will create wrong autolink like https://github.com/github/cmark/issues/57 .
n@. b
will convert to
<p><a href="mailto:n@">n@</a>. b</p>
This causes `URI::InvalidComponentError`.
And I test with Redmine 3.4.2's Markdown formatter with following text.
[a@](a@)
This also causes `URI::InvalidComponentError`.
I wrote some patches to avoid these errors.
Files
- Category changed from Wiki to Text formatting
- Target version set to 4.0.0
I observed the following error when the exception class at source:tags/3.4.2/lib/redmine/helpers/url.rb#L30 is URI::InvalidURIError.
Setting target version to 4.0.0.
$ ruby test/unit/lib/redmine/helpers/url_test.rb
Run options: --seed 58810
# Running:
.E
Error:
URLTest#test_uri_with_safe_scheme_invalid_component:
URI::InvalidComponentError: unrecognised opaque part for mailtoURL: root@
lib/redmine/helpers/url.rb:29:in `uri_with_safe_scheme?'
test/unit/lib/redmine/helpers/url_test.rb:15:in `test_uri_with_safe_scheme_invalid_component'
- Status changed from New to Closed
- Assignee set to Go MAEDA
Committed in the trunk. Thank you for your contribution.
Also available in: Atom
PDF
Updated by