Redmine

You can use raw English text and I think you can use "assert_select_error".
source:trunk/test/functional/auth_sources_controller_test.rb#L142

Toshi MARUYAMA wrote:

You can use raw English text and I think you can use "assert_select_error".
source:trunk/test/functional/auth_sources_controller_test.rb#L142

Do you think using raw text is better? I think I18n.t is better because we don't have to update the test when the English translation for error_can_not_delete_auth_source is changed. And we cannot use assert_select_error for the page because there isn't "div#errorExplanation".

Toshi MARUYAMA wrote:

You can use raw English text and I think you can use "assert_select_error".
source:trunk/test/functional/auth_sources_controller_test.rb#L142

I think that checking the flash hash is a common way to test flash notices. Please see 7.7 Testing flash notices on Rails Guides. Also in Redmine, the same way is used. Examples as follows:

• source:tags/3.4.4/test/functional/timelog_controller_test.rb#L678
• source:tags/3.4.4/test/functional/timelog_controller_test.rb#L689
• source:tags/3.4.4/test/functional/my_controller_test.rb#L362

I think that assert_select_error can be used for validation errors brought by ActiveRecord::Errors object but cannot be used for flash hash.

Go MAEDA wrote:

Toshi MARUYAMA wrote:

You can use raw English text and I think you can use "assert_select_error".
source:trunk/test/functional/auth_sources_controller_test.rb#L142

Do you think using raw text is better?

Yes. Rails changed behaviour many times. It cannot guarantee test result in the future.

I agree with Toshi, using the raw text in the assertion is preferable. It simplifies the statement and makes it more obvious what is expected.