Project

General

Profile

Actions
Copy link

Feature #2835

closed

clickable/linkable line #'s while browsing the repo

Added by Alex U over 15 years ago. Updated about 15 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
UI
Target version:
0.8.2
Start date:
2009-02-25
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

A user on the #redmine channel requests clickable/linkable line numbers while repo browsing. Here is a simple patch for the views and a little css tweak.

worksforme :)

Files

Download all files
linkable_line_numbers.patch (2.19 KB) linkable_line_numbers.patch Alex U, 2009-02-25 01:56
linenumbers_without_css.jpg (30.5 KB) linenumbers_without_css.jpg Mischa The Evil, 2009-02-26 23:25
linenumbers_with_css.jpg (30 KB) linenumbers_with_css.jpg Mischa The Evil, 2009-02-26 23:25
Actions
Copy link
 #1

Updated by Mischa The Evil over 15 years ago

+1, it seems to me that the chosen implementation has a pretty low severity in contrast to a the highly improved useability it provides...

Actions
Copy link
 #2

Updated by Jean-Philippe Lang over 15 years ago

  • Status changed from New to Resolved
  • Target version set to 0.8.2
  • Resolution set to Fixed
Committed in r2527 with sligth changes:
  • title attribute removed (hardcoded english word)
  • change to scm.css removed (not related to this feature)

Thanks.

Actions
Copy link
 #3

Updated by Mischa The Evil over 15 years ago

Jean-Philippe Lang wrote:

Committed in r2527 with sligth changes:
  • ...
  • change to scm.css removed (not related to this feature)

I am in the opinion that it ís related in the sense of the styling of the feature. As such: I think these selectors maybe shouldn't be declared in source:/trunk/public/stylesheets/scm.css. Instead they seem to belong to the source:/trunk/public/stylesheets/application.css.

See the following screenshots:

Without the CSS style-declarations (as committed) With the CSS style-declarations (like the patch)
As you see the changes are:
  • on hover -> underlining removed
  • color -> instead of default link-color a more sophisticated gray-teint is used.

Though, consider it just a minor CSS-improvement... ;)

Thanks for your fast response on this issue...

Actions
Copy link
 #4

Updated by Jean-Philippe Lang over 15 years ago

Yes, sorry. The style is committed in r2555.

Instead they seem to belong to the source:/trunk/public/stylesheets/application.css

scm.css is included when browsing a repo or viewing a file. So I don't think this style is needed in application.css
Am I wrong?

Actions
Copy link
 #5

Updated by Jean-Philippe Lang over 15 years ago

  • Status changed from Resolved to Closed

Merged in 0.8-stable in r2556.

Actions
Copy link
 #6

Updated by Jean-Philippe Lang about 15 years ago

  • Estimated time deleted (0.00 h)
Actions
Copy link

Also available in: Atom PDF