Feature #2835
closedclickable/linkable line #'s while browsing the repo
0%
Description
A user on the #redmine channel requests clickable/linkable line numbers while repo browsing. Here is a simple patch for the views and a little css tweak.
worksforme :)
Files
Updated by Mischa The Evil over 15 years ago
+1, it seems to me that the chosen implementation has a pretty low severity in contrast to a the highly improved useability it provides...
Updated by Jean-Philippe Lang over 15 years ago
- Status changed from New to Resolved
- Target version set to 0.8.2
- Resolution set to Fixed
- title attribute removed (hardcoded english word)
- change to scm.css removed (not related to this feature)
Thanks.
Updated by Mischa The Evil over 15 years ago
- File linenumbers_without_css.jpg linenumbers_without_css.jpg added
- File linenumbers_with_css.jpg linenumbers_with_css.jpg added
Jean-Philippe Lang wrote:
Committed in r2527 with sligth changes:
- ...
- change to scm.css removed (not related to this feature)
I am in the opinion that it ís related in the sense of the styling of the feature. As such: I think these selectors maybe shouldn't be declared in source:/trunk/public/stylesheets/scm.css. Instead they seem to belong to the source:/trunk/public/stylesheets/application.css.
See the following screenshots:
Without the CSS style-declarations (as committed) | With the CSS style-declarations (like the patch) |
![]() |
![]() |
- on
hover
-> underlining removed - color -> instead of default link-color a more sophisticated gray-teint is used.
Though, consider it just a minor CSS-improvement... ;)
Thanks for your fast response on this issue...
Updated by Jean-Philippe Lang over 15 years ago
Yes, sorry. The style is committed in r2555.
Instead they seem to belong to the source:/trunk/public/stylesheets/application.css
scm.css is included when browsing a repo or viewing a file. So I don't think this style is needed in application.css
Am I wrong?
Updated by Jean-Philippe Lang over 15 years ago
- Status changed from Resolved to Closed
Merged in 0.8-stable in r2556.
Updated by Jean-Philippe Lang almost 15 years ago
- Estimated time deleted (
0.00 h)