Project

General

Profile

Actions
Copy link

Patch #28564

closed

JSON API responses cannot have elements named 'request' or 'response'

Added by Jens Krämer over 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Plugin API
Target version:
4.0.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

I stumbled upon this while creating a Plugin with an API.

The problem is that Builders::Structure declares attr_accessor :request, :response. As a consequence, these get called instead of Structure#method_missing when doing api.request or api.response in a .rsb template.

This patch adds a test illustrating the problem and replaces the accessors with direct instance variable usage.

Files

0001-removes-request-and-response-accessors-from-Structur.patch (2.5 KB) 0001-removes-request-and-response-accessors-from-Structur.patch Jens Krämer, 2018-04-17 03:42
Actions
Copy link
 #1

Updated by Go MAEDA over 6 years ago

  • Target version set to Candidate for next minor release
Actions
Copy link
 #2

Updated by Go MAEDA over 6 years ago

  • Category set to REST API
  • Target version changed from Candidate for next minor release to 4.1.0

Setting target version to 4.1.0.

Actions
Copy link
 #3

Updated by Go MAEDA about 6 years ago

  • Category changed from REST API to Plugin API
  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Target version changed from 4.1.0 to 4.0.0

Committed. Thank you for your contribution.

Actions
Copy link

Also available in: Atom PDF