Project

General

Profile

Actions
Copy link

Patch #28934

closed

Support migration context for plugins

Added by Pavel Rosický over 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Rails support
Target version:
4.0.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

https://github.com/rails/rails/commit/a2827ec9811b5012e8e366011fd44c8eb53fc714#diff-8d3c44120f7b67ff79e2fbe6a40d0ad6L1005

Files

Download all files
plugin.rb.patch (3.27 KB) plugin.rb.patch Pavel Rosický, 2018-06-02 00:38
add_unittest.patch (534 Bytes) add_unittest.patch Tatsuya Saito, 2018-06-27 00:41
use_migration_context_with_test.patch (1.06 KB) use_migration_context_with_test.patch Tatsuya Saito, 2018-07-05 16:48
use_migration_context_with_test2.patch (3.54 KB) use_migration_context_with_test2.patch Tatsuya Saito, 2018-07-07 04:23

Related issues

Related to Redmine - Patch #28933: Migrate to Rails 5.2Closed

Actions
Has duplicate Redmine - Defect #29291: NoMethodError: undefined method `migrate' for Redmine::Plugin::Migrator:ClassClosed

Actions
Actions
Copy link
 #2

Updated by Go MAEDA over 6 years ago

Actions
Copy link
 #3

Updated by Tatsuya Saito over 6 years ago

I attach a patch to add simple unit test.
I hope to fix this issue :)

Actions
Copy link
 #4

Updated by Go MAEDA over 6 years ago

  • Category changed from Performance to Rails support
  • Target version set to 4.0.0
Actions
Copy link
 #5

Updated by Toru Takahashi over 6 years ago

+1 this patch is needed to migrate a plugin by redmine:plugins:migrate on rails 5.2.

Actions
Copy link
 #6

Updated by Tatsuya Saito over 6 years ago

I think release version like 3.4.x is NOT going to support Rails 5.2, keep 4.x.
So I created a patch which is removed condition of Rails version check for older than trunk.
I attatch it, and it includes add_unittest.patch.

Actions
Copy link
 #7

Updated by Pavel Rosický over 6 years ago

@Tatsuya Saito
I agree we can remove the rails version check. Your patch is simple, but wrong. It produces invalid entries in schema_migrations! without a plugin_name suffix.

Btw: my patch also loads schema_migrations only once for all plugins, so there's also a performance impact if you have more plugins installed.

Unfortunatelly I have to duplicate MigrationContext because it calls back the original Migrator class from Rails not the patched one by Redmine. Maybe someone can figure out a better solution.

Actions
Copy link
 #8

Updated by Tatsuya Saito over 6 years ago

Pavel Rosický wrote:

@Tatsuya Saito
I agree we can remove the rails version check. Your patch is simple, but wrong. It produces invalid entries in schema_migrations! without a plugin_name suffix.

Thanks comment and sorry broke your patch.
I fix and attach it.

Actions
Copy link
 #9

Updated by Pavel Rosický over 6 years ago

It's ok. Thanks for testing

Actions
Copy link
 #10

Updated by Jean-Philippe Lang about 6 years ago

  • Subject changed from [Rails 5.2] support migration context to Support migration context for plugins
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Committed, thanks.

Actions
Copy link
 #11

Updated by Go MAEDA almost 6 years ago

  • Has duplicate Defect #29291: NoMethodError: undefined method `migrate' for Redmine::Plugin::Migrator:Class added
Actions
Copy link

Also available in: Atom PDF