Actions
Patch #29160
closed
Remove unused and broken method CustomField.visibility_condition
Status:
Closed
Priority:
Normal
Assignee:
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:
0%
Estimated time:
Description
The class method was introduced in r12012 along with the instance method CustomField#visibility_by_project_condition. The method's body seems to follow the idea of the instance method but misses a lot of data required by it, including the user and the project_key. As such, the method would always throw an exception when called.
Since the method is not tested, is never called by Redmine anywhere, and is unusable anyway, we can simply remove it as done by the attached patch.
Files
Related issues
Updated by Go MAEDA over 6 years ago
- Related to Feature #5037: Role-based issue custom field visibility added
Updated by Go MAEDA over 6 years ago
- Target version changed from Candidate for next minor release to 4.0.0
I have confirmed the problem Holger reported. Setting target version to 4.0.0.
Updated by Jean-Philippe Lang about 6 years ago
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
Committed, thanks.
Actions