Feature #29208
closed
Support email addresses with IDN (internationalized domain names) in user accounts
0%
Description
This is a patch to add IDN (internationalized domain names) support to email addresses of user accounts.
Currently, Redmine does not accept IDN email addresses like "joe@ドメイン名例.jp" and its ASCII expression "joe@xn--eckwd4c7cu47r2wf.jp" when creating/updating a user account. After applying this patch, both expressions will be accepted.
According to IDN World Report, there are approx 8.7 millions IDNs in the world as of December 2016, and those are used in many countries. To support IDN email addresses should be beneficial for many people.
This patch converts Unicode domain names to traditional ASCII domain names just before saving an email address. However, it does not convert ASCII domain names to Unicode domain names when displaying email address. Users will see ASCII expression "joe@xn--eckwd4c7cu47r2wf.jp" on my_account page even if they have entered Unicode email address "joe@ドメイン名例.jp".
This approach can minimize the change to existing code and works fine with IDN-unaware MTAs and plugins while allowing people to use IDN email addresses.
"Email" field accepts Unicode domain names:
ASCII converted email address is shown after saving:
References:
Files
Related issues
Updated by Go MAEDA over 6 years ago
- Related to Defect #28878: Email does not support Russian-language domains. added
Updated by Go MAEDA over 6 years ago
- Related to Defect #15985: Email address with non-ASCII character causes delivery error added
Updated by Go MAEDA over 6 years ago
Fixed unnecessary Punycode conversion when an invalid email address is entered.
Updated by Go MAEDA over 6 years ago
Removed unnecessary "require 'simpleidn'".
Updated by Go MAEDA over 6 years ago
Updated the patch.
- Simplified the code by replacing
String#rpartitionwithString#partition. - Added tests to make sure that local-part is not encoded with Punycode.
Updated by Go MAEDA over 6 years ago
- Target version set to 4.1.0
As we can see in #28878, there are already people who are in trouble because of lack of internationalized domain name support. I think that more and more people will start using email addresses with IDN. Let's deliver this feature in the next major release.
Updated by Go MAEDA over 6 years ago
- File 0001-Allow-Punycode-in-email-addresses.patch added
- File 0002-Support-IDN-email-addresses.patch 0002-Support-IDN-email-addresses.patch added
I divided support-idn-email-addresses-v4.diff into two patches. The first one changes only the regular expression to allow Punycode in email addresses. The second one supports email addresses which include Unicode characters in the domain names.
I think that Redmine should support Punycode at least. If 0001-Allow-Punycode-in-email-addresses.patch is merged, a user who has uses an email address "joe@ドメイン名例.jp" can make his account on Redmine by spelling his email address as "joe@xn--eckwd4c7cu47r2wf.jp".
Updated by Go MAEDA over 6 years ago
- File deleted (
0001-Allow-Punycode-in-email-addresses.patch)
Updated by Go MAEDA over 6 years ago
- File 0001-Allow-Punycode-in-email-addresses.patch 0001-Allow-Punycode-in-email-addresses.patch added
Improved the regular expression for email addresses.
Updated by Go MAEDA over 5 years ago
- Target version changed from 4.1.0 to Candidate for next major release
It seems that no one is interested in this feature. Maybe this feature does not worth adding a gem for now.
Updated by Go MAEDA almost 5 years ago
- Related to Defect #32793: Email address with Punycode top-level domain is not accepted added
Updated by Go MAEDA 11 months ago
Go MAEDA wrote in #note-10:
It seems that no one is interested in this feature. Maybe this feature does not worth adding a gem for now.
We can add this feature without adding an extra gem because Addressable gem already used in Redmine supports Puny code conversion.
$ bin/rails c
Loading development environment (Rails 7.1.2)
irb(main):001> Addressable::IDNA.to_ascii('ドメイン名例.jp')
=> "xn--eckwd4c7cu47r2wf.jp"
Updated by Go MAEDA 11 months ago
- File 29208.patch 29208.patch added
- Subject changed from IDN support for email addresses of user accounts to Support email addresses with internationalized domain names in user accounts
I have updated the patch to support email addresses with an internationalized domain name (IDN). This new patch uses an already loaded Addressable gem instead of adding a new gem to decode internationalized domain names.
Updated by Go MAEDA 11 months ago
- Subject changed from Support email addresses with internationalized domain names in user accounts to Support email addresses with IDN (internationalized domain names) in user accounts
- Category changed from Accounts / authentication to I18n
- Target version changed from Candidate for next major release to 6.0.0
Setting the target version to 6.0.0.
Updated by Go MAEDA 4 months ago
- File 29208-utilize-normalize.patch 29208-utilize-normalize.patch added
- Status changed from Closed to Reopened
The attached patch replaces the custom setter address= with the normalizes, introduced in Rails 7.1.