Redmine

Fixed unnecessary Punycode conversion when an invalid email address is entered.

Removed unnecessary "require 'simpleidn'".

Updated the patch.

• Simplified the code by replacing String#rpartition with String#partition.
• Added tests to make sure that local-part is not encoded with Punycode.

As we can see in #28878, there are already people who are in trouble because of lack of internationalized domain name support. I think that more and more people will start using email addresses with IDN. Let's deliver this feature in the next major release.

I divided support-idn-email-addresses-v4.diff into two patches. The first one changes only the regular expression to allow Punycode in email addresses. The second one supports email addresses which include Unicode characters in the domain names.

I think that Redmine should support Punycode at least. If 0001-Allow-Punycode-in-email-addresses.patch is merged, a user who has uses an email address "joe@ドメイン名例.jp" can make his account on Redmine by spelling his email address as "joe@xn--eckwd4c7cu47r2wf.jp".

Improved the regular expression for email addresses.

It seems that no one is interested in this feature. Maybe this feature does not worth adding a gem for now.

I have updated the patch to support email addresses with an internationalized domain name (IDN). This new patch uses an already loaded Addressable gem instead of adding a new gem to decode internationalized domain names.

Setting the target version to 6.0.0.

Committed the patch in r22667.

The attached patch replaces the custom setter address= with the normalizes, introduced in Rails 7.1.

Go MAEDA wrote in #note-16:

The attached patch replaces the custom setter address= with the normalizes, introduced in Rails 7.1.

Committed the change in r23064.