Feature #29435

Render forums list in project settings as table

Added by Bernhard Rohloff over 3 years ago. Updated over 3 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:UI
Target version:-
Resolution:Wont fix

Description

The list of discussion boards is poorly implemented as nested div containers with inline styles and extra CSS classes to look like a table.
I think if it should look like a table, it should also be one.
This also improves the consistency of the UI and reduces the list of CSS classes, theme developers have to style.

View with applied patch series

list_boards_as_a_table_in_project_settings_tab.diff Magnifier - Patch to update the partial (1.62 KB) Bernhard Rohloff, 2018-08-24 14:56

remove_table_list_classes_from_stylesheet.diff Magnifier - Patch to remove the unused CSS styles (1.94 KB) Bernhard Rohloff, 2018-08-24 14:57

new_table_look.png - View with applied patch series (15.9 KB) Bernhard Rohloff, 2018-08-24 15:01


Related issues

Related to Redmine - Feature #29451: Replace tables with components based on nested div contai... New

History

#1 Updated by Marius BALTEANU over 3 years ago

Bernhard, thanks for the patches, but I think that you should see r15337 for #12909 where Jean-Philippe Lang replaced the tables with divs in Forum. Because of that, I think that reverting to a table is not a good idea. Also, I prefer to have divs instead tables and maybe is a good idea to replace on other views the tables with divs.

What we can do is to restore the alternate row colors which is missing now.

Please let me know if I can close this ticket as "Won't fix".

#2 Updated by Marius BALTEANU over 3 years ago

  • Status changed from New to Needs feedback
  • Assignee set to Bernhard Rohloff

#3 Updated by Bernhard Rohloff over 3 years ago

Marius BALTEANU wrote:

Bernhard, thanks for the patches, but I think that you should see r15337 for #12909 where Jean-Philippe Lang replaced the tables with divs in Forum. Because of that, I think that reverting to a table is not a good idea. Also, I prefer to have divs instead tables and maybe is a good idea to replace on other views the tables with divs.

Essentially you are right. Divs would make more sense for responsive designs nowadays. I stumbled upon this particular view while creating a new theme from scratch and I found it an extremely odd and inconsistent experience that I have to apply extra styles for one single table.

What we can do is to restore the alternate row colors which is missing now.

Because it's not a huge problem for the casual user and doesn't effect the default theme that much I would let it as it is.

Please let me know if I can close this ticket as "Won't fix".

I've opened a feature request for replacing the tables in #29451 and you can close this issue in favor for this approach.

#4 Updated by Marius BALTEANU over 3 years ago

  • Tracker changed from Patch to Feature
  • Status changed from Needs feedback to Closed
  • Assignee deleted (Bernhard Rohloff)
  • Resolution set to Wont fix

Thanks.

#5 Updated by Marius BALTEANU over 3 years ago

  • Related to Feature #29451: Replace tables with components based on nested div containers added

Also available in: Atom PDF