Feature #29435: Render forums list in project settings as table - Redmine

Actions

Copy link

Feature #29435

closed

Render forums list in project settings as table

Added by Bernhard Rohloff over 6 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Category:

Target version:

Start date:

Due date:

% Done:

Estimated time:

Resolution:

Wont fix

Description

The list of discussion boards is poorly implemented as nested div containers with inline styles and extra CSS classes to look like a table.
I think if it should look like a table, it should also be one.
This also improves the consistency of the UI and reduces the list of CSS classes, theme developers have to style.

Files

Download all files

list_boards_as_a_table_in_project_settings_tab.diff (1.62 KB) list_boards_as_a_table_in_project_settings_tab.diff	Patch to update the partial	Bernhard Rohloff, 2018-08-24 14:56
remove_table_list_classes_from_stylesheet.diff (1.94 KB) remove_table_list_classes_from_stylesheet.diff	Patch to remove the unused CSS styles	Bernhard Rohloff, 2018-08-24 14:57
new_table_look.png (15.9 KB) new_table_look.png	View with applied patch series	Bernhard Rohloff, 2018-08-24 15:01

Related issues

Actions

Copy link

Updated by Marius BĂLTEANU about 6 years ago

Bernhard, thanks for the patches, but I think that you should see r15337 for #12909 where Jean-Philippe Lang replaced the tables with divs in Forum. Because of that, I think that reverting to a table is not a good idea. Also, I prefer to have divs instead tables and maybe is a good idea to replace on other views the tables with divs.

What we can do is to restore the alternate row colors which is missing now.

Please let me know if I can close this ticket as "Won't fix".

Actions

Copy link

Updated by Marius BĂLTEANU about 6 years ago

Status changed from New to Needs feedback
Assignee set to Bernhard Rohloff

Actions

Copy link

Updated by Bernhard Rohloff about 6 years ago

Marius BALTEANU wrote:

Bernhard, thanks for the patches, but I think that you should see r15337 for #12909 where Jean-Philippe Lang replaced the tables with divs in Forum. Because of that, I think that reverting to a table is not a good idea. Also, I prefer to have divs instead tables and maybe is a good idea to replace on other views the tables with divs.

Essentially you are right. Divs would make more sense for responsive designs nowadays. I stumbled upon this particular view while creating a new theme from scratch and I found it an extremely odd and inconsistent experience that I have to apply extra styles for one single table.