Feature #29946: Update i18n gem (~> 1.6.0) - Redmine

Actions

Copy link

Feature #29946

closed

Update i18n gem (~> 1.6.0)

Added by Go MAEDA over 6 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Go MAEDA

Category:

Gems support

Target version:

4.1.0

Start date:

Due date:

% Done:

Estimated time:

Resolution:

Fixed

Description

The latest version of i18n gem is 1.1.1 but Redmine still uses 0.7.0 that was released 4 years ago.

The reason why Redmine uses the old version is a test failure (see r16324). We should fix the error and should follow the recent version.

Files

Download all files

0001-Updates-i18n-gem-to-1.1.1.patch (1.62 KB) 0001-Updates-i18n-gem-to-1.1.1.patch		Marius BĂLTEANU, 2018-11-17 13:36
0001-Update-i18n-gem-to-1.5.3.patch (2.46 KB) 0001-Update-i18n-gem-to-1.5.3.patch		Marius BĂLTEANU, 2019-02-11 23:44

Related issues

Actions

Copy link

Updated by Marius BĂLTEANU over 6 years ago

I can take a look if you want.

Actions

Copy link

Updated by Go MAEDA over 6 years ago

Marius BALTEANU wrote:

I can take a look if you want.

Thanks. I have not started the work yet, so I am glad if you work on it. Although the priority of this issue is low, we have to upgrade i18n someday.

Actions

Copy link

Updated by Marius BĂLTEANU over 6 years ago

The test that fails on my local environment is the below one and not the one from r16324.

root@45ec3a6558b0:/work# ruby test/unit/lib/redmine/i18n_test.rb 
DEPRECATION WARNING: `secrets.secret_token` is deprecated in favor of `secret_key_base` and will be removed in Rails 6.0. (called from &lt;top (required)&gt; at /work/config/environment.rb:14)
Run options: --seed 36235

# Running:

.........F
Failure:
Redmine::I18nTest#test_fallback [test/unit/lib/redmine/i18n_test.rb:234]:
--- expected
+++ actual
@@ -1 +1 @@
-"Untranslated string" 
+"translation missing: fr.untranslated"

Actions

Copy link

Updated by Marius BĂLTEANU over 6 years ago

File 0001-Updates-i18n-gem-to-1.1.1.patch 0001-Updates-i18n-gem-to-1.1.1.patch added

There are multiple changes between 0.7.0 version and 1.1.1.

One reason of the failing test is https://github.com/svenfuchs/i18n/pull/415 which doesn't consider anymore the default locale as fallback locale. Now you need to explicitly define in the config the fallback locales. For example, if we add the line config.i18n.fallbacks = [:en] to config/application.rb, the above test will pass, but I don't think that should be the solution because from what I've observed until now, we add the en version of the locale to all locale files (which is healthier from point of view).

Attached the patch that updates the gem version and fixes the failing test. The safest way is to schedule this update for 4.1.0 in order to have time to catch missing translation keys (if exists).

Actions

Copy link

Updated by Marius BĂLTEANU over 6 years ago

Marius BALTEANU wrote:

[...] but I don't think that should be the solution because from what I've observed until now, we add the en version of the locale to all locale files (which is healthier from point of view).

It seems that are some missing keys.

Actions

Copy link

Updated by Marius BĂLTEANU over 6 years ago

Assignee set to Marius BĂLTEANU
Target version set to Candidate for next major release

i18n now is at v1.5.3 which supports only Ruby > 2.2. I'll work on this for 4.1.0

Actions

Copy link

Updated by Marius BĂLTEANU over 6 years ago

File 0001-Update-i18n-gem-to-1.5.3.patch 0001-Update-i18n-gem-to-1.5.3.patch added
Assignee deleted (~~Marius BĂLTEANU~~)
Target version changed from Candidate for next major release to 4.1.0

I've attached a new patch with a different fix, but I would like a review on the proposed changes even if all the existing tests pass

The failing test from r16324 was generated by a change to the exists? method which returns true when a fallback exists (please see https://github.com/ruby-i18n/i18n/pull/326).

In my note 3, I wasn't able to reproduce the failing test because the fallback was not enabled.

Actions

Copy link