Defect #29990: Add missing fixtures for test_create_should_send_notification - Redmine

Defect #29990

Add missing fixtures for test_create_should_send_notification

Added by Marius BALTEANU over 3 years ago. Updated over 3 years ago.

Status:

Closed

Start date:

Priority:

Normal

Due date:

Assignee:

Go MAEDA

% Done:

Category:

Code cleanup/refactoring

Target version:

4.0.0

Resolution:

Fixed

Affected version:

Description

The bellow test fails when it is run in isolation

Failure:
CommentTest#test_create_should_send_notification [/builds/marius-balteanu/redmine/test/unit/comment_test.rb:39]:
"ActionMailer::Base.deliveries.size" didn't change by 2.
Expected: 2
  Actual: 1

bin/rails test test/unit/comment_test.rb:35

Attached a patch that adds the missing fixtures.

add_missing_fixtures.patch (562 Bytes) Marius BALTEANU, 2018-11-17 19:44

Related issues

Associated revisions

Revision 17648
Added by Go MAEDA over 3 years ago

Add missing fixtures for test_create_should_send_notification (#29990).

Patch by Marius BALTEANU.

History

#1 Updated by Marius BALTEANU over 3 years ago

Subject changed from Add missing fixtures for test test_create_should_send_notification to Add missing fixtures for test_create_should_send_notification

#2 Updated by Marius BALTEANU over 3 years ago

Description updated (diff)

#3 Updated by Marius BALTEANU over 3 years ago

File add_missing_fixtures_to_documents.patch added

And one more for test/functional/documents_controller_test.rb

root@45ec3a6558b0:/work# ruby test/functional/documents_controller_test.rb 
DEPRECATION WARNING: `secrets.secret_token` is deprecated in favor of `secret_key_base` and will be removed in Rails 6.0. (called from <top (required)> at /work/config/environment.rb:14)
Run options: --seed 39471

# Running:

...........F

Failure:
DocumentsControllerTest#test_create_with_one_attachment [test/functional/documents_controller_test.rb:135]:
Expected: 2
  Actual: 1

bin/rails test test/functional/documents_controller_test.rb:109

...

Finished in 1.231643s, 12.1788 runs/s, 34.9127 assertions/s.
15 runs, 43 assertions, 1 failures, 0 errors, 0 skips