Project

General

Profile

Actions
Copy link

Patch #30177

closed

Thumbnail lifecycle: reuse thumbs from identical files, delete thumbs when diskfile is deleted

Added by Jens Krämer about 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Attachments
Target version:
4.1.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

These patches improve thumbnail handling in two aspects:

  • By changing the naming scheme for thumbnails to not use the attachment ID anymore, already generated thumbnails for identical attachments will be reused.
  • The second patch adds code to remove any thumbnails when the original attachment file is deleted from disk. Without this patch, thumbnails of deleted attachments are never deleted.

Files

Download all files
0001-allows-re-use-of-thumbnails-for-identical-attachment.patch (2.64 KB) 0001-allows-re-use-of-thumbnails-for-identical-attachment.patch Jens Krämer, 2018-12-11 08:49
0002-deletes-thumbnails-when-the-attachment-diskfile-is-d.patch (2.4 KB) 0002-deletes-thumbnails-when-the-attachment-diskfile-is-d.patch Jens Krämer, 2018-12-11 08:49
Actions
Copy link
 #1

Updated by Go MAEDA about 6 years ago

  • Target version set to Candidate for next major release
Actions
Copy link
 #2

Updated by Go MAEDA about 6 years ago

  • Target version changed from Candidate for next major release to 4.1.0

LGTM. We can save disk space with this patch. Setting the target version to 4.1.0.

Actions
Copy link
 #3

Updated by Go MAEDA about 6 years ago

  • Assignee set to Go MAEDA
Actions
Copy link
 #4

Updated by Go MAEDA about 6 years ago

  • Status changed from New to Closed

Committed the patches. Thank you for improving Redmine.

Actions
Copy link

Also available in: Atom PDF