Project

General

Profile

Actions
Copy link

Patch #30241

closed

Update nokogiri gem (~> 1.10.0)

Added by Pavel Rosický about 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Gems support
Target version:
4.0.1
Start date:
Due date:
% Done:

0%

Estimated time:

Description

passed all tests

Files

Gemfile.patch (416 Bytes) Gemfile.patch Pavel Rosický, 2018-12-17 23:42

Related issues

Related to Redmine - Feature #30118: Ruby 2.6 supportClosedJean-Philippe Lang

Actions
Related to Redmine - Feature #30356: Drop Ruby 2.2 supportClosedGo MAEDA

Actions
Actions
Copy link
 #2

Updated by Go MAEDA about 6 years ago

  • Tracker changed from Defect to Patch
  • Target version set to 4.0.1

Thank you for reporting that nokogiri 1.9.0 has been released. I am setting the target version to 4.0.1.

Actions
Copy link
 #3

Updated by Go MAEDA about 6 years ago

  • Target version changed from 4.0.1 to 3.4.8
Actions
Copy link
 #4

Updated by Go MAEDA about 6 years ago

  • Status changed from New to Resolved
Actions
Copy link
 #5

Updated by Go MAEDA about 6 years ago

  • Status changed from Resolved to Closed
  • Assignee set to Go MAEDA
  • Target version changed from 3.4.8 to 4.0.1

Committed. Thanks.

Actions
Copy link
 #6

Updated by Pavel Rosický almost 6 years ago

  • Status changed from Closed to Reopened

Go MAEDA -> FYI Nokogiri 1.10.0 has been released on 2019-01-04

this version includes Ruby 2.6 support on Windows #30118

Actions
Copy link
 #7

Updated by Go MAEDA almost 6 years ago

Actions
Copy link
 #8

Updated by Go MAEDA almost 6 years ago

Actions
Copy link
 #9

Updated by Go MAEDA almost 6 years ago

  • Subject changed from Update nokogiri gem (~> 1.9.0) to Update nokogiri gem (~> 1.10.0)

Nokogiri requires Ruby >= 2.3.0 but Redmine 4.0.0 officially supports Ruby 2.2.2. I have opened #30356 to drop support for Ruby 2.2.

$ bundle update
 .
 .
 .
Bundler could not find compatible versions for gem "ruby":
  In Gemfile:
    ruby

    nokogiri (~> 1.10.0) was resolved to 1.10.0, which depends on
      ruby (>= 2.3.0)
Actions
Copy link
 #10

Updated by Go MAEDA almost 6 years ago

  • Status changed from Reopened to Closed

Committed.
Uses Nokogiri 1.9 for Ruby 2.2, 1.10 for Ruby >=2.3.

Actions
Copy link

Also available in: Atom PDF