Redmine

Maybe it is enough to return 404 when the request format is HTML?

diff --git a/app/controllers/watchers_controller.rb b/app/controllers/watchers_controller.rb
index 3f080e9..cec2519 100644
--- a/app/controllers/watchers_controller.rb
+++ b/app/controllers/watchers_controller.rb
@@ -30,7 +30,10 @@ class WatchersController < ApplicationController
   accept_api_auth :create, :destroy

   def new
-    @users = users_for_new_watcher
+    respond_to do |format|
+      format.html { render_404 }
+      format.js { @users = users_for_new_watcher }
+    end
   end

   def create

All tests pass with the above patch applied:
Test results: https://gitlab.com/marius-balteanu/redmine/-/jobs/155499251
Patch: https://gitlab.com/marius-balteanu/redmine/commit/bcf9de280551a69d5b449a5d569560cb191926aa.diff

Since I use MacBook Pro and don't have a mouse with a middle button, I cannot reproduce the problem. Adding issue watchers works fine for me.

Could someone tell me how the middle button works and causes the error?

Yes, middle button means Open link in new tab. To reproduce, go to an issue, right click on the Add watchers link and then Open link in a new tab. Technically, instead of an Ajax request you will do a simple get request.

Marius BALTEANU wrote:

Yes, middle button means Open link in new tab.

Thanks, I understand. I think this issue is not a big problem, so the fix that simply returns 404 is enough.

I found that this issue also affects the following links.

• "Watch" link
• "Search for watchers to add" link on "New issue" page