Project

General

Custom queries



Profile

Actions

Defect #31120

closed

Garbage lines in the output of 'git branch' break git adapter

Added by Chad Petersen about 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
SCM
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

I found that adding an if condition around line 84-89 solves the issue.

change:

branch_rev = line.match('\s*(\*?)\s*(.*?)\s*([0-9a-f]{40}).*$')
bran = GitBranch.new(branch_rev[2])
bran.revision =  branch_rev[3]
bran.scmid    =  branch_rev[3]
bran.is_default = ( branch_rev[1] == '*' )
@branches << bran

To:

if branch_rev = line.match('\s*(\*?)\s*(.*?)\s*([0-9a-f]{40}).*$')
  bran = GitBranch.new(branch_rev[2])
  bran.revision =  branch_rev[3]
  bran.scmid    =  branch_rev[3]
  bran.is_default = ( branch_rev[1] == '*' )
  @branches << bran
end


Files

31120.patch (1.09 KB) 31120.patch Fix by Chad Petersen Go MAEDA, 2019-03-31 06:39
#2

Updated by Go MAEDA about 6 years ago

  • Description updated (diff)
#3

Updated by Go MAEDA about 6 years ago

#4

Updated by Go MAEDA about 6 years ago

  • Status changed from New to Needs feedback
#6

Updated by Go MAEDA about 6 years ago

  • Tracker changed from Patch to Defect
  • Subject changed from Git commit with multi-line comment on a project with more than one branch breaking parser. to Git commit with multi-line comment on a project with more than one branch breaking parser
  • Status changed from Needs feedback to New
  • Target version set to 3.4.11
#7

Updated by Go MAEDA about 6 years ago

  • Subject changed from Git commit with multi-line comment on a project with more than one branch breaking parser to Multi-line commit message breaks git adapter when parsing branches
#8

Updated by Go MAEDA about 6 years ago

  • Subject changed from Multi-line commit message breaks git adapter when parsing branches to Garbage lines in the output of 'git branch' break git adapter
  • Status changed from New to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed
#9

Updated by Go MAEDA about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF