Actions
Patch #31324
closed
Allow to set is_private flag through a keyword in emails
Description
Currently it is impossible to set the is_private flag of an issue with an email keyword. The attached patch developed for Planio changes that.
The code will recognize yes/no values according to the users' and the default locale, as well as 0/1.
Files
Related issues
Updated by Go MAEDA almost 5 years ago
- Status changed from New to Needs feedback
- Assignee set to Jens Krämer
Thank you for posting the patch. But the test fails.
Failure: MailHandlerTest#test_add_issue_with_private_keyword [test/unit/mail_handler_test.rb:507]: Expected false to be truthy. bin/rails test test/unit/mail_handler_test.rb:499
I found the following line in log/test.log.
MailHandler: missing information from John Smith: Unable to determine target project
Updated by Jens Krämer almost 5 years ago
My bad I admit I just ran the test against 3.4 (where it passed). I'll fix that tomorrow.
Updated by Jens Krämer almost 5 years ago
- File 0001-allows-setting-the-private-flag-via-mail-keyword.patch 0001-allows-setting-the-private-flag-via-mail-keyword.patch added
here's the fixed patch - the test email was still tailored to Planio's customized mail handler which is why it failed on vanilla Redmine.
Updated by Go MAEDA almost 5 years ago
- Status changed from Needs feedback to New
- Assignee deleted (
Jens Krämer) - Target version set to Candidate for next major release
The patch passed the test. Thanks!
Updated by Go MAEDA almost 5 years ago
- Status changed from New to Closed
- Assignee set to Go MAEDA
- Target version changed from Candidate for next major release to 4.1.0
Committed the patch. Thank you for your contribution.
Updated by Go MAEDA almost 5 years ago
- Related to Feature #8424: Add private issue option to receiving emails added
Actions