Patch #31334
closed
Do not lose content when updating a wiki page that has been renamed in the meantime
Description
This is a corner case, but it happened recently with a client here at Planio.
When somebody renames a wiki page while somebody else is editing it, the latter will lose any updates to the content upon save due to the redirect performed by the find_existing_or_new_page before action.
This patch adds an integration test that reproduces the behavior, and fixes it by replacing the before action with a simple call to @wiki.find_or_new_page(params[:id]) in update.
Files
Updated by Go MAEDA over 5 years ago
- Target version set to Candidate for next minor release
Updated by Go MAEDA over 5 years ago
- Target version changed from Candidate for next minor release to 3.4.11
Setting the target version to 3.4.11.
Updated by Go MAEDA over 5 years ago
- Status changed from New to Needs feedback
- Assignee set to Jens Krämer
I had to change the name of the class WikiTest in test/integration/wiki_test.rb to run bin/rails test because it conflicts with the class WikiTest in test/unit/wiki_test.rb. I encountered the following error.
/path/to/redmine/test/unit/wiki_test.rb:22:in `<top (required)>': superclass mismatch for class WikiTest (TypeError)
Do you think what class name is appropriate?
Updated by Jens Krämer over 5 years ago
Oh well :) What about WikiIntegrationTest?
Updated by Go MAEDA over 5 years ago
- Status changed from Needs feedback to New
- Assignee deleted (
Jens Krämer)
Jens Krämer wrote:
Oh well :) What about WikiIntegrationTest?
Looks nice!
Updated by Go MAEDA over 5 years ago
- Status changed from New to Closed
- Assignee set to Go MAEDA
Committed the patch. Thank you for reporting and fixing this issue.