Actions
Defect #31507
closedTest fails if trailing whitespaces are removed
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
The test test_partials_with_html_entities
fails if the trailing whitespaces are removed. The attached patch can be used to reproduce the below problem:
notroot@eb7d0b73147d:/work$ ruby test/unit/lib/redmine/unified_diff_test.rb -n test_partials_with_html_entities
DEPRECATION WARNING: `secrets.secret_token` is deprecated in favor of `secret_key_base` and will be removed in Rails 6.0. (called from <top (required)> at /work/config/environment.rb:16)
Run options: -n test_partials_with_html_entities --seed 55482
# Running:
E
Error:
Redmine::UnifiedDiffTest#test_partials_with_html_entities:
NoMethodError: undefined method `html_line_left' for nil:NilClass
test/unit/lib/redmine/unified_diff_test.rb:106:in `test_partials_with_html_entities'
bin/rails test test/unit/lib/redmine/unified_diff_test.rb:92
I wasn't able to fix the test without changing the diff, any solution is welcome.
Files
Related issues
Updated by Marius BĂLTEANU over 5 years ago
- Related to Patch #31506: Remove trailing whitespaces added
Updated by Go MAEDA over 5 years ago
- File fix-31507.patch fix-31507.patch added
Here is my patch. I could not think of any other solution.
Updated by Go MAEDA 10 months ago
- File 31507.patch 31507.patch added
The problem can be fixed with the attached patch. The patch changes the test data not to include blank lines.
Updated by Go MAEDA 10 months ago
- File 31507-v2.patch 31507-v2.patch added
This new patch also fixes another two tests, test_keep_similar_git_footer_line
and test_git_footer_line
, and removes trailing white spaces.
Actions