Project

General

Profile

Actions

Defect #31507

open

Test fails if trailing whitespaces are removed

Added by Marius BALTEANU over 4 years ago. Updated over 4 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Code cleanup/refactoring
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Affected version:

Description

The test test_partials_with_html_entities fails if the trailing whitespaces are removed. The attached patch can be used to reproduce the below problem:


notroot@eb7d0b73147d:/work$ ruby test/unit/lib/redmine/unified_diff_test.rb -n test_partials_with_html_entities
DEPRECATION WARNING: `secrets.secret_token` is deprecated in favor of `secret_key_base` and will be removed in Rails 6.0. (called from <top (required)> at /work/config/environment.rb:16)
Run options: -n test_partials_with_html_entities --seed 55482

# Running:

E

Error:
Redmine::UnifiedDiffTest#test_partials_with_html_entities:
NoMethodError: undefined method `html_line_left' for nil:NilClass
    test/unit/lib/redmine/unified_diff_test.rb:106:in `test_partials_with_html_entities'

bin/rails test test/unit/lib/redmine/unified_diff_test.rb:92

I wasn't able to fix the test without changing the diff, any solution is welcome.


Files


Related issues

Related to Redmine - Patch #31506: Remove trailing whitespacesClosedGo MAEDA

Actions
Actions #1

Updated by Marius BALTEANU over 4 years ago

  • Description updated (diff)
Actions #2

Updated by Marius BALTEANU over 4 years ago

  • Related to Patch #31506: Remove trailing whitespaces added
Actions #3

Updated by Go MAEDA over 4 years ago

Here is my patch. I could not think of any other solution.

Actions

Also available in: Atom PDF