Patch #31640
closed
Add clear query icon next to selected query in sidebar
Description
Now that "All issues" link was removed from the sidebar, we should have an easier way in sidebar to clear the current query.
My proposal is to add a Clear link next to selected query link:
On hover:
Files
Related issues
Updated by Marius BĂLTEANU over 5 years ago
- File 0001-Add-clear-link-icon-for-selected-query-in-sidebar.patch added
Updated by Marius BĂLTEANU over 5 years ago
- Related to Patch #30294: Move the links (View all issues, Summary, Import) from the Issues section of the issues list sidebar under a dropdown added
Updated by Marius BĂLTEANU over 5 years ago
- File deleted (
0001-Add-clear-link-icon-for-selected-query-in-sidebar.patch)
Updated by Marius BĂLTEANU over 5 years ago
- File 0001-Add-clear-link-icon-for-selected-query-in-sidebar.patch 0001-Add-clear-link-icon-for-selected-query-in-sidebar.patch added
Fixed some Rubocop warnings.
Updated by Marius BĂLTEANU over 5 years ago
All tests pass: https://gitlab.com/redmine-org/redmine/pipelines/68625213
Updated by Go MAEDA over 5 years ago
Although I understand the reason why you use 
(reload.png), I think the current icon used in your patch is not appropriate because it looks like a button to reload the current query. In my opinion, the icon should be the one similar to 
(close.png).
Updated by Marius BĂLTEANU over 5 years ago
- File clear_with_close.png clear_with_close.png added
- File 0001-Add-clear-link-icon-for-selected-query-in-sidebar_2.patch 0001-Add-clear-link-icon-for-selected-query-in-sidebar_2.patch added
Go MAEDA wrote:
Although I understand the reason why you use
Agree, but (close.png) icon is not so visible:
Attached the updated patch. Go Maeda, if you have a better idea, please fell free to update my patch.
Updated by Go MAEDA over 5 years ago
- File clear_with_close_hl@2x.png clear_with_close_hl@2x.png added
- File 31910.patch added
- Target version changed from Candidate for next major release to 4.1.0
Marius BALTEANU wrote:
Agree, but
Using 
(close_hl.png) looks nicer.
Updated by Marius BĂLTEANU over 5 years ago
Go MAEDA wrote:
Marius BALTEANU wrote:
Agree, but
Using
Indeed, close_hl.png is better.
Regarding the patch, you have attached a wrong one.
Updated by Go MAEDA over 5 years ago
- File 31640-close_hl.patch 31640-close_hl.patch added
Marius BALTEANU wrote:
Regarding the patch, you have attached a wrong one.
Sorry, here is the correct patch.
Updated by Go MAEDA over 5 years ago
- Status changed from New to Closed
- Assignee set to Go MAEDA
Committed the patch. Thank you for improving Redmine.