Actions
Defect #32198
closedIssues associated revisions not showing due to bad reference to lvar instead of ivar
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
Fixes bad references on issue_controller
This is the error
NameError in IssuesController#issue_tab undefined local variable or method `changesets' for #<IssuesController:0x0000556756ef61f0> Did you mean? @changesets Extracted source (around line #207): #205 when 'changesets' #206 @changesets = @issue.changesets.visible.preload(:repository, :user).to_a *207 changesets.reverse! if User.current.wants_comments_in_reverse_order? #208 render :partial => 'issues/tabs/changesets', :locals => {:changesets => @changesets} #209 end #210 end Extracted source (around line #6): #4 module BasicImplicitRender # :nodoc: #5 def send_action(method, *args) *6 super.tap { default_render unless performed? } #7 end #8 #9 def default_render(*args) Extracted source (around line #194): #192 # which is *not* necessarily the same as the action name. #193 def process_action(method_name, *args) *194 send_action(method_name, *args) #195 end #196 #197 # Actually call the method associated with the action. Override
Files
Related issues
Updated by Mischa The Evil about 5 years ago
- Related to Feature #3058: Show issue history using tabs added
Updated by Mischa The Evil about 5 years ago
- Subject changed from Issues associated revisión not showing due to bad reference to Issues associated revisions not showing due to bad reference to lvar instead of ivar
Updated by Go MAEDA about 5 years ago
- Tracker changed from Patch to Defect
- Status changed from New to Confirmed
- Target version set to 4.1.0
Updated by Go MAEDA about 5 years ago
- Status changed from Confirmed to Resolved
- Assignee set to Go MAEDA
- Target version deleted (
4.1.0) - Resolution set to Fixed
Committed the patch as a part of #3058. Thank you for detecting and reporting this issue.
Updated by José Esteves about 5 years ago
Go MAEDA wrote:
Committed the patch as a part of #3058. Thank you for detecting and reporting this issue.
Glad to help! :)
Actions