Defect #32307

AttachmentsControllerTest#test_thumbnail_for_pdf_should_be_png fails if ImageMagick convert is not available

Added by Go MAEDA almost 3 years ago. Updated almost 3 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Code cleanup/refactoring
Target version:-
Resolution:Fixed Affected version:

Description

To reproduce it, set invalid value to imagemagick_convert_command in configuration.yml and run attachments_controller_test.rb.

Failure:
AttachmentsControllerTest#test_thumbnail_for_pdf_should_be_png [/Users/maeda/redmines/redmine-trunk/test/functional/attachments_controller_test.rb:478]:
Expected response to be a <2XX: success>, but was a <404: Not Found>
Response body:

bin/rails test test/functional/attachments_controller_test.rb:472

The test should be skipped if convert command is not available.


Related issues

Related to Redmine - Feature #22481: Show thumbnails for PDF attachments Closed

Associated revisions

Revision 18826
Added by Go MAEDA almost 3 years ago

Skip AttachmentsControllerTest#test_thumbnail_for_pdf_should_be_png when ImageMagick convert is not available (#32307, #22481).

Patch by Go MAEDA.

History

#1 Updated by Go MAEDA almost 3 years ago

  • Status changed from New to Closed
  • Target version deleted (Candidate for next major release)
  • Resolution set to Fixed

Committed the patch as a part of #22481.

#2 Updated by Marius BALTEANU almost 3 years ago

  • Related to Feature #22481: Show thumbnails for PDF attachments added

Also available in: Atom PDF