Defect #32664

Adding an empty reply to a forum message does not show any error

Added by Go MAEDA 3 months ago. Updated about 1 month ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Forums
Target version:Candidate for next major release
Resolution: Affected version:

Description

Steps to reproduce:

1. Open any forum topic and click "Reply"
2. Attach any file and click "Submit"
3. You will see "Successful update" message but the reply is not added. The attachment is silently discarded

Expected behavior:

"Content cannot be blank" error should be shown.

show_any_error_when_reply.png (210 KB) Yuichi HARADA, 2019-12-25 02:30

32664_show_errormsg_submitting_reply.patch Magnifier (3.92 KB) Yuichi HARADA, 2019-12-25 02:32

32664_show_errormsg_submitting_reply-v2.patch Magnifier (5.89 KB) Yuichi HARADA, 2020-01-16 06:04

History

#1 Updated by Yuichi HARADA 3 months ago

Show any error message when submitting a reply. I attached a patch.
However, I'm worried that if the number of replies increases, the error message, and the reply input fields will be separated.

#2 Updated by Go MAEDA 3 months ago

Yuichi HARADA wrote:

However, I'm worried that if the number of replies increases, the error message, and the reply input fields will be separated.

You are right. Thank you for pointing it out.

And I found that the behavior that showing an error is not consistent with issues. When updating issues, no error is shown even if note is empty. Its behavior is similar to forums but the only difference is the behavior when adding attachments with an empty note. In the case, attachments are added to the issue.

I think the following behavior is better for forums. It is consistent with the behavior of issues.

  • Empty message without attachments: Almost the same behavior with the current behavior but "Successful update" message should not be shown
  • empty message with attachments: Attach the files instead of discarding them

#3 Updated by Yuichi HARADA 2 months ago

Go MAEDA wrote:

I think the following behavior is better for forums. It is consistent with the behavior of issues.

  • Empty message without attachments: Almost the same behavior with the current behavior but "Successful update" message should not be shown
  • empty message with attachments: Attach the files instead of discarding them

Thank you for pointing it out. I attached a patch that incorporates the above behaviors.

#4 Updated by Go MAEDA about 1 month ago

  • Target version set to Candidate for next major release

Also available in: Atom PDF