Patch #32813
Clean up toggleMultiSelect js function
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Go MAEDA | % Done: | 0% | |
| Category: | Code cleanup/refactoring | |||
| Target version: | 4.2.0 |
Description
The attached patch cleans up toggleMultiSelect function(toggle_multiple_select.gif).
- 0001. Unify the process to toggleMultiSelect written in workflows/permissions, workflows/edit, and query_filter respectively
- 0002. Fix app/controllers/workflows_controller.rb that should have changed along with #15988
(It works like toggle_role_selectbox.gif due to the problem)
0002-Fix-roles.patch 
(1.66 KB)
0001-Unify-processing-for-switching-multiple-selections.patch
(7.09 KB)
toggle_multiple_select.gif (88.2 KB)
toggle_role_selectbox.gif (491 KB)
Associated revisions
Clean up toggleMultiSelect js function (#32813).
Patch by Mizuki ISHIKAWA.
History
#2
Updated by Go MAEDA 3 months ago
Mizuki ISHIKAWA wrote:
- 0002. Fix app/controllers/workflows_controller.rb that should have changed along with #15988
(It works like toggle_role_selectbox.gif due to the problem)
I think it is another issue. It is not a code cleanup but a bug. I think it should be handled by another new issue. What do you think?
#3
Updated by Mizuki ISHIKAWA 3 months ago
Go MAEDA wrote:
Mizuki ISHIKAWA wrote:
- 0002. Fix app/controllers/workflows_controller.rb that should have changed along with #15988
(It works like toggle_role_selectbox.gif due to the problem)I think it is another issue. It is not a code cleanup but a bug. I think it should be handled by another new issue. What do you think?
I created a issue reporting the bug and attached a patch. #33059
#4
Updated by Go MAEDA 3 months ago
- Target version changed from Candidate for next major release to 4.2.0
Setting the target version to 4.2.0.
Since 0002-Fix-roles.patch has already been committed in r19538, the patch to be committed is only 0001-Unify-processing-for-switching-multiple-selections.patch.