Patch #32813

Clean up toggleMultiSelect js function

Added by Mizuki ISHIKAWA 5 months ago. Updated 2 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Code cleanup/refactoring
Target version:4.2.0

Description

The attached patch cleans up toggleMultiSelect function(toggle_multiple_select.gif).

0002-Fix-roles.patch Magnifier (1.66 KB) Mizuki ISHIKAWA, 2020-01-15 07:03

0001-Unify-processing-for-switching-multiple-selections.patch Magnifier (7.09 KB) Mizuki ISHIKAWA, 2020-01-15 07:03

toggle_multiple_select.gif (88.2 KB) Mizuki ISHIKAWA, 2020-01-15 07:04

toggle_role_selectbox.gif (491 KB) Mizuki ISHIKAWA, 2020-01-15 07:04

Associated revisions

Revision 19604
Added by Go MAEDA 2 months ago

Clean up toggleMultiSelect js function (#32813).

Patch by Mizuki ISHIKAWA.

History

#1 Updated by Go MAEDA 4 months ago

  • Target version set to Candidate for next major release

#2 Updated by Go MAEDA 3 months ago

Mizuki ISHIKAWA wrote:

I think it is another issue. It is not a code cleanup but a bug. I think it should be handled by another new issue. What do you think?

#3 Updated by Mizuki ISHIKAWA 3 months ago

Go MAEDA wrote:

Mizuki ISHIKAWA wrote:

I think it is another issue. It is not a code cleanup but a bug. I think it should be handled by another new issue. What do you think?

I created a issue reporting the bug and attached a patch. #33059

#4 Updated by Go MAEDA 3 months ago

  • Target version changed from Candidate for next major release to 4.2.0

Setting the target version to 4.2.0.

Since 0002-Fix-roles.patch has already been committed in r19538, the patch to be committed is only 0001-Unify-processing-for-switching-multiple-selections.patch.

#5 Updated by Go MAEDA 2 months ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch. Thank you.

#6 Updated by Go MAEDA 2 months ago

  • Subject changed from Clean up toggleMultiSelect function to Clean up toggleMultiSelect js function

Also available in: Atom PDF