Patch #32890

Fix violations reported by Stylelint

Added by Marius BALTEANU 8 months ago. Updated 8 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Code cleanup/refactoring
Target version:4.2.0

Description

Linting the CSS files using the rules proposed in #32888 generates the following violations:

root@df2fd1389bf4:/work# node_modules/.bin/stylelint "public/stylesheets/**/*.css" 

public/stylesheets/application.css
  561:1   ✖  Unexpected duplicate selector "div#issue-changesets div.changeset", first used at line 560   no-duplicate-selectors                   
  682:77  ✖  Unexpected duplicate "pre"                                                                   declaration-block-no-duplicate-properties
 1084:1   ✖  Unexpected duplicate selector "table.progress", first used at line 1075                      no-duplicate-selectors                   
 1560:1   ✖  Unexpected duplicate selector ".sort-handle", first used at line 706                         no-duplicate-selectors                   
 1619:83  ✖  Unexpected duplicate "color"                                                                 declaration-block-no-duplicate-properties

public/stylesheets/responsive.css
 264:18  ✖  Unexpected missing generic font family                                                                                                  font-family-no-missing-generic-family-keyword
 804:3   ✖  Unexpected duplicate selector "#issue_tree .issue > td:not(.checkbox), #relations .issue > td:not(.checkbox)", first used at line 787   no-duplicate-selectors                       
 828:3   ✖  Unexpected duplicate selector "#issue_tree .issue > td.subject,   #relations .issue > td.subject", first used at line 799               no-duplicate-selectors                       

public/stylesheets/rtl.css
 322:21  ✖  Unexpected duplicate "margin-right"   declaration-block-no-duplicate-properties
 377:14  ✖  Unexpected empty block                block-no-empty

The attached patches fix all of them with one exception 828:3 ✖ Unexpected duplicate selector "#issue_tree .issue > td.subject, #relations .issue > td.subject", first used at line 799 no-duplicate-selectors which should be fixed by #32889.

0007-Fix-duplicate-margin-right-property.patch Magnifier (741 Bytes) Marius BALTEANU, 2020-01-26 22:01

0006-Remove-empty-block.patch Magnifier (733 Bytes) Marius BALTEANU, 2020-01-26 22:01

0004-Fix-missing-generic-font-family.patch Magnifier (700 Bytes) Marius BALTEANU, 2020-01-26 22:01

0005-Fix-duplicate-selector.patch Magnifier (1.2 KB) Marius BALTEANU, 2020-01-26 22:01

0003-Fix-duplicate-color-attribute.patch Magnifier (1.16 KB) Marius BALTEANU, 2020-01-26 22:01

0001-Remove-duplicate-white-space-property.patch Magnifier (950 Bytes) Marius BALTEANU, 2020-01-26 22:01

0002-Fix-duplicate-selectors.patch Magnifier (2.18 KB) Marius BALTEANU, 2020-01-26 22:01


Related issues

Related to Redmine - Patch #32888: Use stylelint to avoid errors and enforce conventions in ... Closed

Associated revisions

Revision 19471
Added by Go MAEDA 8 months ago

Remove duplicate white-space property (#32890).

Patch by Marius BALTEANU.

Revision 19472
Added by Go MAEDA 8 months ago

Fix duplicate selectors (#32890).

Patch by Marius BALTEANU.

Revision 19473
Added by Go MAEDA 8 months ago

Fix duplicate "color" attribute (#32890).

Patch by Marius BALTEANU.

Revision 19474
Added by Go MAEDA 8 months ago

Fix missing generic font family (#32890).

Patch by Marius BALTEANU.

Revision 19475
Added by Go MAEDA 8 months ago

Fix duplicate selector (#32890).

Patch by Marius BALTEANU.

Revision 19476
Added by Go MAEDA 8 months ago

Remove empty block (#32890).

Patch by Marius BALTEANU.

Revision 19477
Added by Go MAEDA 8 months ago

Fix duplicate "margin-right" property (#32890).

Patch by Marius BALTEANU.

History

#1 Updated by Go MAEDA 8 months ago

  • Target version changed from Candidate for next major release to 4.2.0

Setting the target version to 4.2.0.

#2 Updated by Go MAEDA 8 months ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patches. Thank you.

#3 Updated by Marius BALTEANU 8 months ago

  • Related to Patch #32888: Use stylelint to avoid errors and enforce conventions in CSS files added

Also available in: Atom PDF