Feature #33592
Include updated_on and passwd_changed_on columns in users API response
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Go MAEDA | % Done: | 0% | |
| Category: | REST API | |||
| Target version: | 4.2.0 | |||
| Resolution: | Fixed |
Description
Users CSV has updated_on and passwd_changed_on column since r19740. I think it is inconsistent that the values are not included in API response.
0001-Add_fields_to_users_api.patch 
(1.27 KB)
0002-Add_assertions_to_users_api_integration_test.patch
(2.32 KB)
Related issues
Associated revisions
Include updated_on and passwd_changed_on columns in API response (#33592).
Patch by vzvu 3k6k and Takenori TAKAKI.
History
#1
Updated by Go MAEDA over 1 year ago
- Related to Feature #33347: Include updated_on and passwd_changed_on columns when exporting users to CSV added
#2
Updated by vzvu 3k6k over 1 year ago
- File 0001-Add_fields_to_users_api.patch added
I've attached a patch to add these fields to user API, written by @Takenori TAKAKI and me. Tests for these changes will be posted later.
#3
Updated by vzvu 3k6k over 1 year ago
I've attached a patch to ensure these fields are correctly added.
But I'm afraid that these assertions might be too detailed. For now Redmine::ApiTest::UsersTest doesn't have tests for individual fields except for id and some optional fields.
I wonder if we should add assertions for other fields too, or just drop this test patch to keep test code simple.
#4
Updated by Go MAEDA about 1 year ago
- Target version set to Candidate for next minor release
#5
Updated by Go MAEDA about 1 year ago
- Target version changed from Candidate for next minor release to 4.2.0
Setting the target version to 4.2.0.
#6
Updated by Go MAEDA about 1 year ago
- Status changed from New to Closed
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the patch. Thank you for your contribution.
#7
Updated by Go MAEDA about 1 year ago
- Related to Defect #33787: Redmine::ApiTest::UsersTest fail if config.time_zone is set added