Feature #33592

Include updated_on and passwd_changed_on columns in API response

Added by Go MAEDA 4 months ago. Updated 3 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:REST API
Target version:4.2.0
Resolution:Fixed

Description

Users CSV has updated_on and passwd_changed_on column since r19740. I think it is inconsistent that the values are not included in API response.

0001-Add_fields_to_users_api.patch Magnifier (1.27 KB) vzvu 3k6k, 2020-06-25 09:06

0002-Add_assertions_to_users_api_integration_test.patch Magnifier (2.32 KB) vzvu 3k6k, 2020-06-25 23:57


Related issues

Related to Redmine - Feature #33347: Include updated_on and passwd_changed_on columns when exp... Closed
Related to Redmine - Defect #33787: Redmine::ApiTest::UsersTest fail if config.time_zone is set Closed

Associated revisions

Revision 19940
Added by Go MAEDA 3 months ago

Include updated_on and passwd_changed_on columns in API response (#33592).

Patch by vzvu 3k6k and Takenori TAKAKI.

Revision 19942
Added by Go MAEDA 3 months ago

Redmine::ApiTest::UsersTest fails if config.time_zone is set (#33592, #33787).

Patch by Yuichi HARADA.

History

#1 Updated by Go MAEDA 4 months ago

  • Related to Feature #33347: Include updated_on and passwd_changed_on columns when exporting users to CSV added

#2 Updated by vzvu 3k6k 4 months ago

I've attached a patch to add these fields to user API, written by @Takenori TAKAKI and me. Tests for these changes will be posted later.

#3 Updated by vzvu 3k6k 4 months ago

I've attached a patch to ensure these fields are correctly added.

But I'm afraid that these assertions might be too detailed. For now Redmine::ApiTest::UsersTest doesn't have tests for individual fields except for id and some optional fields.

I wonder if we should add assertions for other fields too, or just drop this test patch to keep test code simple.

#4 Updated by Go MAEDA 4 months ago

  • Target version set to Candidate for next minor release

#5 Updated by Go MAEDA 3 months ago

  • Target version changed from Candidate for next minor release to 4.2.0

Setting the target version to 4.2.0.

#6 Updated by Go MAEDA 3 months ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you for your contribution.

#7 Updated by Go MAEDA 3 months ago

  • Related to Defect #33787: Redmine::ApiTest::UsersTest fail if config.time_zone is set added

Also available in: Atom PDF