Feature #34123

System tests for inline auto complete feature

Added by Marius BALTEANU 7 months ago. Updated about 1 month ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:UI
Target version:4.1.2
Resolution:Fixed

Description

We should add some system tests (or other type) for the inline autocomplete feature.

0001-Add-system-tests-for-inline-autocomplete.patch Magnifier (5.02 KB) Marius BALTEANU, 2020-12-05 16:50

fix_assert_param_order.patch Magnifier (524 Bytes) Marius BALTEANU, 2020-12-17 00:24

Associated revisions

Revision 20580
Added by Go MAEDA 5 months ago

Add system tests for inline autocomplete (#34123).

Patch by Marius BALTEANU.

Revision 20652
Added by Go MAEDA 5 months ago

Fix the order of assert params (#34123).

Revision 20826
Added by Go MAEDA about 1 month ago

Merged r20580 and r20652 from trunk to 4.1-stable (#34123).

History

#1 Updated by Marius BALTEANU 5 months ago

I've added a first version of the tests. I preferred to have all the tests related to inline autocomplete in the same file instead of splitting them in different files (issues_test, news_test, etc).

Any feedback is appreciated.

#2 Updated by Go MAEDA 5 months ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you.

#3 Updated by Marius BALTEANU 5 months ago

  • File fix_assert_param_order.patch added
  • Status changed from Closed to Reopened

Please commit the attached patch, I made a mistake in the initial patch (first param is the expected value, the second is the actual).

https://apidock.com/ruby/Test/Unit/Assertions/assert_equal

#4 Updated by Marius BALTEANU 5 months ago

  • File deleted (fix_assert_param_order.patch)

#6 Updated by Go MAEDA 5 months ago

  • Status changed from Reopened to Closed

Marius BALTEANU wrote:

Please commit the attached patch, I made a mistake in the initial patch (first param is the expected value, the second is the actual).

Committed the fix in r20652. Thank you.

#7 Updated by Go MAEDA about 1 month ago

  • Target version changed from 4.2.0 to 4.1.2

Changing the target version to 4.1.2 in order to apply #33846 to 4.1-stable.

Also available in: Atom PDF