Project

General

Profile

Actions
Copy link

Patch #34444

closed

Remove unused key :preview from Redmine::AccessKeys::ACCESSKEYS

Added by Go MAEDA over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Code cleanup/refactoring
Target version:
4.2.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

As reported in #30459, Redmine 4.0 and later no longer supports the accesskey "r" (updates the preview in editor mode) due to the improvement of UI made by #27758.

The definition of the accesskey should be removed.

diff --git a/lib/redmine/access_keys.rb b/lib/redmine/access_keys.rb
index db66c7d84..a64ac0673 100644
--- a/lib/redmine/access_keys.rb
+++ b/lib/redmine/access_keys.rb
@@ -22,7 +22,6 @@ module Redmine
     unless const_defined?(:ACCESSKEYS)
       ACCESSKEYS = {
         :edit => 'e',
-        :preview => 'r',
         :quick_search => 'f',
         :search => '4',
         :new_issue => '7',

Related issues

Related to Redmine - Feature #27758: Adds preview option to the wiki toolbarClosedJean-Philippe Lang

Actions
Related to Redmine - Feature #30459: Switch edit/preview tabs with keyboard shortcutsClosedGo MAEDA

Actions
Actions
Copy link
 #1

Updated by Go MAEDA over 4 years ago

  • Related to Feature #27758: Adds preview option to the wiki toolbar added
Actions
Copy link
 #2

Updated by Go MAEDA over 4 years ago

  • Related to Feature #30459: Switch edit/preview tabs with keyboard shortcuts added
Actions
Copy link
 #3

Updated by Go MAEDA over 4 years ago

  • Target version set to 4.2.0

Setting the target version to 4.2.0.

Actions
Copy link
 #4

Updated by Go MAEDA over 4 years ago

  • Subject changed from Remove :preview from Redmine::AccessKeys::ACCESSKEYS to Remove unused key :preview from Redmine::AccessKeys::ACCESSKEYS
  • Assignee set to Go MAEDA

Committed the patch.

Actions
Copy link
 #5

Updated by Go MAEDA over 4 years ago

  • Status changed from New to Closed
Actions
Copy link

Also available in: Atom PDF