Project

General

Profile

Actions
Copy link

Defect #34743

closed

Hooks for queries helper

Added by Alexander Meindl almost 4 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Hook requests
Target version:
5.0.0
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Plugin developers very often overwrite queries helper column_value and column_content.

The problem is, that there two ways to overwrite it: prepend and alias_method. There is a conflict if one plugin uses prepend and the other plugin uses alias_method for the same method.

More and more plugins do not work together because of this reason. Because of this, there should be a better way to solve this wish to overwrite.

I added a patch to introduce two hooks, which could be used by plugin develops. With this approach there is no need for overwriting this method anymore.

Files

Download all files
queries_helper.patch (3.87 KB) queries_helper.patch Alexander Meindl, 2021-02-14 08:06
34743-v2.patch (3.63 KB) 34743-v2.patch patch by Alexander Meindl Go MAEDA, 2021-07-11 05:00
Actions
Copy link
 #1

Updated by Go MAEDA almost 4 years ago

Alexander Meindl wrote:

Plugin developers very often overwrite queries helper column_value and column_content.

Could you show me some plugins that do that?

Actions
Copy link
 #2

Updated by Alexander Meindl almost 4 years ago

Hi Go MAEDA,

thanks for responding.

Here is a list of some plugins which overwrites query helper methods:

Actions
Copy link
 #3

Updated by Go MAEDA almost 4 years ago

  • Target version set to Candidate for next major release
Actions
Copy link
 #4

Updated by Chris Lockwood over 3 years ago

Hi Go MAEDA

Can anything be done to bring forward the integration of this patch? This has the potential to solve a fairly sizable problem hampering plugin developers, and users of those plugins alike.

Quickly perusing what is listed in Candidate for next major release and it seems like many enhancements simply go there to die, numerous patches are 5+ years old. Please do reconsider whether this solution can be safely implemented within the next minor release.

Actions
Copy link
 #5

Updated by Go MAEDA over 3 years ago

Adjusted indentation to conform with the current coding style of Redmine.

Setting the target version to 5.0.0.

Actions
Copy link
 #6

Updated by Go MAEDA over 3 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you.

Actions
Copy link
 #7

Updated by Go MAEDA about 3 years ago

  • Subject changed from Hooks for queries helper to Hooks for queries helper
Actions
Copy link
 #8

Updated by Dimitar (RedmineUP) about 2 years ago

Hi Alexander,

This is Dimitar from the RedmineUP Support Team.

Just for information, as a note, all our plugins are compatible with Redmine 5+ :)

Screenshot reference (by now the latest Redmine version is the one from the screenshot below ---> 5.0.4 stable):

If there are any problems with the compatibility (or any other questions) with the RedmineUP plugins, please feel free to contact us at . Thanks.

Alexander Meindl wrote:

Hi Go MAEDA,

thanks for responding.

Here is a list of some plugins which overwrites query helper methods:

Actions
Copy link
 #9

Updated by Alexander Meindl about 2 years ago

Dimitar Chervenakov wrote:

Hi Alexander,

This is Dimitar from the RedmineUP Support Team.

Just for information, as a note, all our plugins are compatible with Redmine 5+ :)

Hi Dimitar,

this issue is not about Redmine 5 compatibility, it is about prepend and alias_method incompatibility. If every plugin would use the more modern way with prepend, a lot of problems with compatibility would be solved. Sadly Redmineup plugins stick to alias_method.

Actions
Copy link

Also available in: Atom PDF