Feature #34787

Ability to set default value for "I don't want to be notified of changes that I make myself"

Added by Pierre DEPREY 7 months ago. Updated 6 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Email notifications
Target version:4.2.0
Resolution:Fixed

Description

Hello,

I search many possibilites to change the default value of no_self_notified when creating a new user.
Actually default is true.

line 54 to 56 in /app/models/user_preference.rb

unless attributes && attributes.key?(:no_self_notified)
  self.no_self_notified = true
end

might be :

unless attributes && attributes.key?(:no_self_notified)
  self.no_self_notified = Setting.default_users_no_self_notified
end

and add in config/settings.yml

default_users_no_self_notified:
  default: true

With this change, we can modify the default value without changing source code of Redmine.

this may be implemented in a future release ?

Regards,

Pierre

settings.png (53.3 KB) Go MAEDA, 2021-02-23 14:49

34787.patch Magnifier (2.23 KB) Go MAEDA, 2021-02-23 15:03


Related issues

Related to Redmine - Feature #14574: "I don't want to be notified of changes that I make mysel... Closed
Duplicated by Redmine - Feature #24629: Add option to decide default value for "I don't want to b... Closed

Associated revisions

Revision 20771
Added by Go MAEDA 6 months ago

Ability to set default value for "I don't want to be notified of changes that I make myself" (#34787).

Patch by Go MAEDA.

History

#1 Updated by Go MAEDA 7 months ago

  • Related to Feature #14574: "I don't want to be notified of changes that I make myself" as Default for all User added

#2 Updated by Go MAEDA 7 months ago

Here is a patch to implement the feature. Admin > Settings > Users will have "I don't want to be notified of changes that I make myself" checkbox.

#3 Updated by Pierre DEPREY 7 months ago

  • Status changed from New to Resolved

Thank you, this patch is exactly what i've needed.

#4 Updated by Marius BALTEANU 7 months ago

  • Status changed from Resolved to New

We should keep this ticket in "New" until the patch is committed.

#5 Updated by Marius BALTEANU 7 months ago

  • Target version set to Candidate for next major release

#6 Updated by Go MAEDA 7 months ago

  • Subject changed from ability to set default value for no_self_notified in config/settings.yml to Ability to set default value for "I don't want to be notified of changes that I make myself"
  • Target version changed from Candidate for next major release to 4.2.0

Setting the target version to 4.2.0.

#7 Updated by Go MAEDA 6 months ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch.

#8 Updated by Go MAEDA 6 months ago

  • Duplicated by Feature #24629: Add option to decide default value for "I don't want to be notified of changes that I make myself" added

Also available in: Atom PDF