Defect #3483: Relative url for source links in notifications - Redmine

Actions

Copy link

Defect #3483

closed

Relative url for source links in notifications

Added by William Baum almost 16 years ago. Updated over 10 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Jean-Philippe Lang

Category:

Email notifications

Target version:

2.5.2

Start date:

2009-06-12

Due date:

% Done:

80%

Estimated time:

Resolution:

Fixed

Affected version:

2.2.1

Description

The email of an issue that includes a "source:" link is included in the email as a relative link ala:

<a href="/repositories/entry/..." class="source">source:...</a>

The link needs to be made absolute.

Not sure if this applies to other links besides source: links..

Ruby version 1.8.6 (i386-mswin32)
RubyGems version 1.3.1
Rails version 2.1.2

Files

source_export-only_path.patch (895 Bytes) source_export-only_path.patch

William Baum, 2009-10-19 06:25

Related issues

Updated by William Baum over 15 years ago

File source_export-only_path.patch source_export-only_path.patch added
% Done changed from 0 to 80

This issue should be resolved with the attached patch.

The link_to for source: and export: links wasn't setting :only_path => only_path, so the links weren't being converted to absolute links in emails, etc..

Index: app/helpers/application_helper.rb
===================================================================
--- app/helpers/application_helper.rb    (revision 2879)
+++ app/helpers/application_helper.rb    (working copy)
@@ -527,7 +527,7 @@
             if project && project.repository
               name =~ %r{^[/\\]*(.*?)(@([0-9a-f]+))?(#(L\d+))?$}
               path, rev, anchor = $1, $3, $5
-              link = link_to h("#{prefix}:#{name}"), {:controller => 'repositories', :action => 'entry', :id => project,
+              link = link_to h("#{prefix}:#{name}"), {:only_path => only_path, :controller => 'repositories', :action => 'entry', :id => project,
                                                       :path => to_path_param(path),
                                                       :rev => rev,
                                                       :anchor => anchor,

Please also see Feature #4052 for additional enhancements to source and export links, as well as enhancements to commit, and revision links from #3346.

--Bill